Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding errors in mikrotik device tracker #13464

Merged
merged 1 commit into from Mar 26, 2018

Conversation

bdurrer
Copy link
Contributor

@bdurrer bdurrer commented Mar 25, 2018

Description:

This PR fixes a bug where devices and/or networks with non-ascii characters crash the mikrotik device tracker.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): no influence on docs

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: mikrotik
    host: 10.10.10.10
    username: homeassistant
    password: badpassword

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.66 milestone Mar 26, 2018
@balloob balloob merged commit 8ab5978 into home-assistant:dev Mar 26, 2018
@balloob
Copy link
Member

balloob commented Mar 26, 2018

Thanks! 🐬

@balloob balloob mentioned this pull request Mar 30, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
@bdurrer bdurrer deleted the bugfix/mikrotik-tracker branch February 18, 2019 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants