Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Homekit to 1.1.9 #13716

Merged
merged 2 commits into from
Apr 6, 2018
Merged

Update Homekit to 1.1.9 #13716

merged 2 commits into from
Apr 6, 2018

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Apr 6, 2018

Changelog:

  • No longer necessary to call self.char.set_value(value, should_callback=False) in the setter_callback method
  • The parameter should_callback has been removed from set_value
  • Tests should use client_update_value instead of set_value to emulate char set by HomeKit

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@balloob balloob merged commit 8548761 into home-assistant:dev Apr 6, 2018
@cdce8p cdce8p deleted the homekit-1.1.9 branch April 6, 2018 15:45
@balloob balloob mentioned this pull request Apr 27, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants