Update beacontools to 1.2.3 #13792
Merged
Update beacontools to 1.2.3 #13792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: sensor.eddystone_temperature
small-pr
|
I know that the Xiaomi Miio lib is moving away from the Construct lib because the Construct maintainer is making breaking changes left and right every patch version. When they complained about it, Constructor maintainer talked about that they should just wipe your tears and fix their code. |
Merged
Adminiuga
pushed a commit
to Adminiuga/home-assistant
that referenced
this pull request
Jun 25, 2018
ghost
added
integration: eddystone_temperature
and removed
platform: sensor.eddystone_temperature
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
constructdevelopers, again, made a breaking change in a minor version update (2.9.41) which breaks my librarybeacontools. This PR updates the version to 1.2.3 to fix this issue.Checklist:
tox. Your PR cannot be merged unless tests pass