Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup on exit #13918

Merged
merged 6 commits into from Apr 17, 2018
Merged

Cleanup on exit #13918

merged 6 commits into from Apr 17, 2018

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Apr 15, 2018

Description:

This pull request adds a cleanup callback and respective supporting library version bump.

The version bump to the supporting library actually fixes an issue with environments using uvloop (BUG FIX)

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: mediarooom

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable.
  • New dependencies are only imported inside functions that use them.
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

kellerza
kellerza reviewed Apr 15, 2018
View reviewed changes
homeassistant/components/media_player/mediaroom.py Outdated
responses_callback=callback_notify)

async def stop_discovery(event):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be just a @callback imported from homeassistant.core?

Copy link
Contributor Author

@dgomes dgomes Apr 15, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@balloob balloob merged commit 8fdeebc into home-assistant:dev Apr 17, 2018
@balloob balloob mentioned this pull request Apr 27, 2018
Merged
@dgomes dgomes deleted the cleanup_discovery branch May 7, 2018 22:00
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kellerza kellerza kellerza left review comments

Assignees
No one assigned
Labels
cla-signed integration: mediaroom small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dgomes @kellerza @balloob @homeassistant