Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming icons #13982

Merged
merged 3 commits into from Apr 18, 2018
Merged

renaming icons #13982

merged 3 commits into from Apr 18, 2018

Conversation

NovapaX
Copy link
Contributor

@NovapaX NovapaX commented Apr 18, 2018

Description:

this started with: home-assistant/frontend/issues/1003 and http://templarian.com/2018/04/18/material-design-icons-v2-3-50/

but added a default icon for vacuums in frontend so removed these from the backend: see home-assistant/frontend#1108

also changed the tuner icon to use a radio instead of a thermostat icon....

Copy link
Member

@syssi syssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the icon overrides as far as the default icon is used.

@NovapaX
Copy link
Contributor Author

NovapaX commented Apr 18, 2018

So that would be all the vacuum components that have ICON = 'mdi:robot-vacuum' specified?

@balloob balloob merged commit 45eb611 into home-assistant:dev Apr 18, 2018
@NovapaX NovapaX deleted the fix/rename-icons branch April 18, 2018 21:27
@balloob balloob mentioned this pull request Apr 27, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants