-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple Doorbird stations #13994
Merged
syssi
merged 24 commits into
home-assistant:dev
from
oblogic7:multiple_doorbird_support
Jun 10, 2018
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3a85104
Support for multiple DoorBird devices
oblogic7 2d9fb0a
Remove accidental commit of partial component
oblogic7 332e6d1
Formatting
oblogic7 c3907b0
Correct indentation
oblogic7 21c5c38
May this offering please the linting gods.
oblogic7 0dfade4
Requested change to config schema
oblogic7 a37e86e
Requested schema update.
oblogic7 98e7339
Punctuation
oblogic7 645bfac
Move doorbell events to proper binary sensor.
oblogic7 ccac2c4
Fix linting issues.
oblogic7 8fa3267
Correct motion event so it will register with the device properly
oblogic7 783b268
Apply timeout to motion sensor too since we do not receive a push eve…
oblogic7 1780f30
Linting issues
oblogic7 08ec5e1
Another lint fix
oblogic7 9aa0e05
Suggested changes
oblogic7 e55556f
Undo binary sensor changes. Fire events for motion and doorbell acti…
oblogic7 e485192
Hound wanted a treat
oblogic7 8966636
Missed one.
oblogic7 3e29719
Lint fixes
oblogic7 1b19410
More lint fixes
oblogic7 1ef8fff
Suggested changes
oblogic7 334a3f0
Add blank line
oblogic7 d0e511e
Missed a requested change
oblogic7 26a93bd
Exclude notification reset if not specified on config
oblogic7 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you call the event motion? I will approved and merge the PR afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the event name required by the device API for event subscriptions.
https://www.doorbird.com/downloads/api_lan.pdf?rev=0.20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Sounds a bit weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oblogic7 That's only for
monitor.cgi
. The newschedule.cgi
uses 'motion'. No need to update this PR, I'm fixing it in mine 🙂