Refactored units and icons for the Dyson sensors

[glpatcern]

Description:

This PR bears a number of improvements for the Dyson sensors, to bring them to the HA standard:

• a default icon is assigned to all sensors
• sensor name initials are capitalized
• the unit of measurement for the levels/indexes is empty, This may be questionable, but from a measurement point of view, quality indexes are pure numbers.
• the "air quality" sensor was renamed AQI for Air Quality Index, following Dyson's mobile app

The latter change is a breaking change.

Related issue (if applicable): N/A

Pull request in home-assistant.github.io with documentation (if applicable): N/A (though the sensors' names could be documented)

Example entry for configuration.yaml (if applicable): N/A

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[syssi]

I assume None is preferred instead of an empty string.

[glpatcern]

Well spotted, I see other sensors having None indeed as unit. Fixed by the next commit.

[fabaff]

@CharlesBlonde, could you please take a look at this? Thanks

[MartinHjelmare]

Use super to call the parent class init method.

[MartinHjelmare]

Don't pass in hass. It will be set on the entity when it has been added to home assistant.

[glpatcern]

Ah, good to know. It's true that most of the sensors do not have hass in the __init__() signature (but a good fraction of them still has it...).

I'm happy to do the change, but just to note that both suggestions refer to the original code, not to this PR, and my attempt was to minimize the change.

[MartinHjelmare]

Since you're changing these lines, please clean it up.

[MartinHjelmare]

super().__init__(device, 'filter_life')

[CharlesBlonde]

Hi, I'm quite busy right now but I'll try to take a look at this issue this weekend ! Le jeu. 31 mai 2018 à 14:27, Martin Hjelmare <notifications@github.com> a écrit :

…

***@***.**** commented on this pull request. ------------------------------ In homeassistant/components/sensor/dyson.py <#14550 (comment)> : > @@ -43,12 +51,13 @@ def setup_platform(hass, config, add_devices, discovery_info=None): class DysonSensor(Entity): """Representation of Dyson sensor.""" - def __init__(self, hass, device): + def __init__(self, hass, device, sensor_type): Since you're changing these lines, please clean it up. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14550 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQj8KHfMF5Q1eBlL7m0I_NA7txiERbnks5t3-HMgaJpZM4UF4lu> .

[glpatcern]

Hi @CharlesBlonde, whenever you can please have a look at the latest version, which includes an overall refactoring. It works for my setup.

[glpatcern]

For info, the CI test failed because in the test environment it seems that hass is not set on the entity:

self = <Entity Device_name Filter Life: None>, force_refresh = False
    def schedule_update_ha_state(self, force_refresh=False):
        """Schedule an update ha state change task.
    
            That avoid executor dead looks.
            """
>       self.hass.add_job(self.async_update_ha_state(force_refresh))
E       AttributeError: 'NoneType' object has no attribute 'add_job'

Whereas in the real environment that works. @MartinHjelmare, what would be your suggestion to fix the tests?

[MartinHjelmare]

Simple way is to set hass attribute on each entity before calling on_message. You have access to hass as self.hass in the tests. The longer route would be to actually add the devices to home assistant during platform setup before calling on_message.

[MartinHjelmare]

Looks good!

[MartinHjelmare]

I'll wait for @CharlesBlonde or @fabaff to give the go ahead.

[MartinHjelmare]

@CharlesBlonde or @fabaff any further input? Otherwise I'll merge.

[glpatcern]

As a side note, I didn't further push for this because lately the Dyson integration is broken for me for about a month now. Nothing related to Home Assistant, but rather the underlying libpurecoollink is unable to logon, as if Dyson upgraded their logon logic.

Did not have time to debug it, but maybe @CharlesBlonde knows more and/or experienced the same? If so, that's obviously out of scope for this PR and we should follow it up with libpurecoollink.