NUT sensor enhancements #14570
Merged
NUT sensor enhancements #14570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy when connection to nut unavailable; output human-readable state name by default
… raw value of current status in more info dialog
…t used to display a human-readable form of the status
homeassistant
added
cla-signed
platform: sensor.nut
small-pr
syssi
reviewed
May 21, 2018
| @@ -209,11 +215,12 @@ def unit_of_measurement(self): | |||
| def device_state_attributes(self): | |||
| """Return the sensor attributes.""" | |||
| attr = dict() | |||
| attr[ATTR_STATE] = self.opp_state() | |||
| attr[ATTR_STATE] = self.display_state() + " (" + \ | |||
| self._data.status[KEY_STATUS] + ")" | |||
There was a problem hiding this comment.
Please use format() instead of concats (+)
There was a problem hiding this comment.
Sure, makes sense.
syssi
approved these changes
May 21, 2018
2 tasks
syssi
reviewed
May 21, 2018
| @@ -209,11 +215,12 @@ def unit_of_measurement(self): | |||
| def device_state_attributes(self): | |||
| """Return the sensor attributes.""" | |||
| attr = dict() | |||
| attr[ATTR_STATE] = self.opp_state() | |||
| attr[ATTR_STATE] = "{} ({})".format(self.display_state(), | |||
There was a problem hiding this comment.
If you are very accurate this is a breaking change. I would remove the duplicate info here. What do you think?
There was a problem hiding this comment.
Yes, you are right. And with the introduction of a separate sensor type for the human-readable status, the additional information in the more info dialogue is probably not necessary anymore.
…man-readable status without the raw value
syssi
approved these changes
May 22, 2018
|
Is this still a breaking change now that the more info dialogue output remains untouched? |
|
Oh! You are right. I've removed the tag again. |
|
Thank you @exxamalte for this fix! 👍 |
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
…14324) * removed default value from required parameter; raising PlatformNotReady when connection to nut unavailable; output human-readable state name by default * removed superfluous sensor name part; showing human-readable form and raw value of current status in more info dialog * introduced a new virtual sensor type based on the raw status value but used to display a human-readable form of the status * renamed method * format string instead of concatenation * revert the change to the device state attributes - only output the human-readable status without the raw value
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This proposal makes the NUT sensor a bit more user-friendly, and contains the following changes:
ups.status.displaywhich outputs the UPS status in a human-readable form. For example, outputs "Online Battery Charging" instead of "OL CHRG" on the sensor's state card.Change the more info dialog output by appending the raw status value to the human-readable form. Example output: "state . Online Battery Charging (OL CHRG)".PlatformNotReadyto make HA try again after a few seconds.Related issue (if applicable): fixes #14324
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5411
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: