Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mfi.py to include mFi-DS Door Sensors #14667

Merged
merged 1 commit into from May 29, 2018
Merged

Update mfi.py to include mFi-DS Door Sensors #14667

merged 1 commit into from May 29, 2018

Conversation

Bakkoda
Copy link
Contributor

@Bakkoda Bakkoda commented May 28, 2018

Add ability to read door sensor states from the mPort.

Description:

Assuming your mFi setup is already working with Home Assistant this will also allow the Door Sensors to be polled from the mPort. A quick sensor template will show them as doors.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

binary_sensor:
  - platform: template
    sensors: 
        front_door:
            friendly_name: "Your Door Name"
            device_class: door
            value_template: '{{ states("sensor.door") == "0.0" }}'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Add ability to read door sensor states from the mPort.
@Bakkoda Bakkoda changed the title Update mfi.py Update mfi.py to include mFi-DS Door Sensors May 28, 2018
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 79efb0e into home-assistant:dev May 29, 2018
@balloob balloob mentioned this pull request Jun 8, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: mfi small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants