New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add turn_on/off service to Nest Camera #14880
Add turn_on/off service to Nest Camera #14880
Conversation
camera.is_recording = False | ||
|
||
hass.services.async_register( | ||
DOMAIN, SERVICE_TURN_ON, service_handler, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefix the service name with the platform name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
camera.nest.turn_on? or camera.nest_turn_on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
camera.nest_turn_on
9ddf5c1
to
84ae097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Can be merged when build passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not merge this as there is a pending discussion by the author to add this to the camera component. If added to the camera component, we would have to remove these again.
Withdrawn PR due home-assistant/architecture#35 |
Description:
Allow turn on/off Nest Camera streaming.
Resolve issue mentioned in https://community.home-assistant.io/t/enable-disable-nest-camera-recording/54874
Related issue (if applicable): fixes
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5512
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: