Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add turn_on/off service to Nest Camera #14880

Conversation

awarecan
Copy link
Contributor

@awarecan awarecan commented Jun 9, 2018

Description:

Allow turn on/off Nest Camera streaming.
Resolve issue mentioned in https://community.home-assistant.io/t/enable-disable-nest-camera-recording/54874

Related issue (if applicable): fixes

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5512

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

camera.is_recording = False

hass.services.async_register(
DOMAIN, SERVICE_TURN_ON, service_handler,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix the service name with the platform name.

Copy link
Contributor Author

@awarecan awarecan Jun 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camera.nest.turn_on? or camera.nest_turn_on?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camera.nest_turn_on

@awarecan awarecan force-pushed the add-nest-camera-turn-on-off-service branch from 9ddf5c1 to 84ae097 Compare June 10, 2018 14:07
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MartinHjelmare
Copy link
Member

Can be merged when build passes.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not merge this as there is a pending discussion by the author to add this to the camera component. If added to the camera component, we would have to remove these again.

@awarecan
Copy link
Contributor Author

Withdrawn PR due home-assistant/architecture#35

@awarecan awarecan closed this Jun 16, 2018
@ghost ghost removed the in progress label Jun 16, 2018
@awarecan awarecan deleted the add-nest-camera-turn-on-off-service branch August 22, 2018 12:19
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants