Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deCONZ small improvements #15128

Merged
merged 3 commits into from Jun 24, 2018
Merged

deCONZ small improvements #15128

merged 3 commits into from Jun 24, 2018

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jun 24, 2018

Description:

Imports wouldn't work since bridge id wasn't available
Make deconz lights report color values properly
Pydeconz now uses aiohttp websockets

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned Kane610 Jun 24, 2018
@ghost ghost added the in progress label Jun 24, 2018
MartinHjelmare
MartinHjelmare approved these changes Jun 24, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Kane610
Copy link
Member Author

Kane610 commented Jun 24, 2018

Thanks @MartinHjelmare !

Now the waiting game for the tests...

@bachya bachya merged commit 5a71a22 into home-assistant:dev Jun 24, 2018
@ghost ghost removed the in progress label Jun 24, 2018
@Kane610 Kane610 deleted the deconz-small-improvements branch June 25, 2018 04:38
eavanvalkenburg pushed a commit to eavanvalkenburg/home-assistant that referenced this pull request Jun 28, 2018
@Kane610 @eavanvalkenburg
deCONZ small improvements (home-assistant#15128)
16c1139 
* Make sure that bridge id is available for config entry

* Fix so deconz reports proper color values

* Bump dependency to v39
@balloob balloob mentioned this pull request Jul 6, 2018
Merged
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@Kane610
deCONZ small improvements (home-assistant#15128)
2c5ca8c 
* Make sure that bridge id is available for config entry

* Fix so deconz reports proper color values

* Bump dependency to v39
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
@ghost ghost removed the platform: light.deconz label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@Kane610 Kane610

Labels
cla-signed integration: deconz small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kane610 @MartinHjelmare @bachya @homeassistant