Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DarkSky weather / Fix states #15174

Merged
merged 3 commits into from Jun 28, 2018
Merged

DarkSky weather / Fix states #15174

merged 3 commits into from Jun 28, 2018

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jun 27, 2018

Description:

Make darksky weather working

@homeassistant homeassistant added platform: weather.darksky small-pr PRs with less than 30 lines. labels Jun 27, 2018
@ghost ghost assigned pvizeli Jun 27, 2018
@ghost ghost added the in progress label Jun 27, 2018

@property
def forecast(self):
"""Return the forecast array."""
return [{
ATTR_FORECAST_TIME:
datetime.fromtimestamp(entry.d.get('time')).isoformat(),
ATTR_FORECAST_TEMP: entry.d.get('temperature')}
for entry in self._ds_hourly.data]
ATTR_FORECAST_TEMP:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

Copy link
Contributor

@dgomes dgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvizeli pvizeli merged commit dbb786c into dev Jun 28, 2018
@ghost ghost removed the in progress label Jun 28, 2018
@pvizeli pvizeli deleted the darksky-weather branch June 28, 2018 10:23
@balloob balloob mentioned this pull request Jul 6, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
* DarkSky weather / Fix states

* fix lint

* fix tests
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants