New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DarkSky weather / Fix states #15174
Merged
Merged
DarkSky weather / Fix states #15174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
platform: weather.darksky
small-pr
PRs with less than 30 lines.
labels
Jun 27, 2018
ghost
assigned pvizeli
Jun 27, 2018
ghost
added
the
in progress
label
Jun 27, 2018
houndci-bot
reviewed
Jun 27, 2018
|
||
@property | ||
def forecast(self): | ||
"""Return the forecast array.""" | ||
return [{ | ||
ATTR_FORECAST_TIME: | ||
datetime.fromtimestamp(entry.d.get('time')).isoformat(), | ||
ATTR_FORECAST_TEMP: entry.d.get('temperature')} | ||
for entry in self._ds_hourly.data] | ||
ATTR_FORECAST_TEMP: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace
dgomes
approved these changes
Jun 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ghost
removed
the
in progress
label
Jun 28, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* DarkSky weather / Fix states * fix lint * fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make darksky weather working