New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity service #15991
Entity service #15991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow!
Looks awesome. Just needs tests I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a perfect
It doesn't need tests as all entity components have tests for all services already (famous last words) |
Right now we call all commands in sequence. We should explore leveraging the |
Description:
Introduces a new helper to help entity components defining services. Bonus: when executing a service, will run entities of different platforms in parallel. This should give a significant boost if you are controlling, for example, a Hue and a LIFX bulb at the same time.
Approach 1: Will call entity.async_open_cover
Approach 2: Will call passed in function with
entity, call
and expects coroute returnedRelated issue (if applicable): #15989
Checklist:
tox
. Your PR cannot be merged unless tests passIf the code does not interact with devices: