Store devices as dict instead of list #16229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Aug 27, 2018
| @@ -86,10 +86,10 @@ def async_get_or_create(self, *, config_entry, connections, identifiers, | |||
| devices = await self._store.async_load() | |||
|
|
|||
| if devices is None: | |||
| self.devices = [] | |||
| self.devices = {} | |||
balloob
reviewed
Aug 27, 2018
| @@ -7,7 +7,7 @@ | |||
| def mock_registry(hass, mock_entries=None): | |||
| """Mock the Device Registry.""" | |||
| registry = device_registry.DeviceRegistry(hass) | |||
| registry.devices = mock_entries or [] | |||
| registry.devices = mock_entries or {} | |||
balloob
approved these changes
Aug 27, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
tox. Your PR cannot be merged unless tests pass