Fix sonos async use #17099
Merged
Fix sonos async use #17099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Entry setup wasn't using the async api. Fix this by using correct async api.s * Also use new async executor scheduler in async_added_to_hass.
homeassistant
added
cla-signed
platform: media_player.sonos
small-pr
ghost
assigned 
|
@amelchio I can't test this live. I've written a test that calls the scheduler and that works, but it doesn't really add so much since the incorrect previous usage doesn't fail that test. Not sure where we best should test this or how. I can push that commit with the test if we want. |
amelchio
approved these changes
Oct 3, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: