Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic support of the Philips Zhirui desk lamp (philips.light.mono1) #17258

Merged
merged 1 commit into from Oct 9, 2018
Merged

Add basic support of the Philips Zhirui desk lamp (philips.light.mono1) #17258

merged 1 commit into from Oct 9, 2018

Conversation

syssi
Copy link
Member

@syssi syssi commented Oct 8, 2018 •
edited

Description:

syssi/philipslight#13

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6619

Example entry for configuration.yaml (if applicable):

light:
  - platform: xiaomi_miio
    name: Philips desk lamp
    host: 192.168.130.67
    token: da548d86f55996413d82eea94279d2ff
    model: philips.light.mono1

@syssi syssi requested a review from rytilahti as a code owner October 8, 2018 19:00
@ghost ghost assigned syssi Oct 8, 2018
@ghost ghost added the in progress label Oct 8, 2018
@homeassistant homeassistant added platform: light.xiaomi_miio small-pr PRs with less than 30 lines. labels Oct 8, 2018
@syssi syssi mentioned this pull request Oct 8, 2018
Merged
rytilahti
rytilahti approved these changes Oct 8, 2018
View reviewed changes
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@balloob balloob merged commit 757ba3b into home-assistant:dev Oct 9, 2018
@ghost ghost removed the in progress label Oct 9, 2018
@balloob
Copy link
Member

balloob commented Oct 9, 2018

@rytilahti feel free to hit that merge button 😉

@balloob balloob mentioned this pull request Oct 26, 2018
Merged
@jokerigno
Copy link

Hi, this implementation works also for the xiaomi Philips bedside lamp?

@MartinHjelmare
Copy link
Member

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees

@syssi syssi

Labels
cla-signed integration: xiaomi_miio small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@syssi @balloob @jokerigno @MartinHjelmare @rytilahti @homeassistant