Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Neato states, actions and alerts based on Neato docs #17353

Merged

Conversation

dshokouhi
Copy link
Member

@dshokouhi dshokouhi commented Oct 12, 2018

Description:

Neato has updated their actions and alerts, this PR updates the integration to include those changes and also removes unused states: https://developers.neatorobotics.com/api/robot-remote-protocol/request-response-formats

Breaking Change:
The vacuum status attribute has new alerts and updated actions.

Related issue (if applicable): fixes # N/A

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io# N/A

Example entry for configuration.yaml (if applicable):

neato:
  username: username
  password: password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like changing the action values is a breaking change since it changes part of vacuum state attributes. Same for alerts. Is this correct?

@@ -32,6 +32,7 @@
}, extra=vol.ALLOW_EXTRA)

STATES = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used? I can't find usage in any of the platforms.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took a closer look, I don't think these STATES were ever used (not even imported). They were actually added in switch.neato when the component was first created. I will remove this and test it out before submitting a change.

Copy link
Member Author

@dshokouhi dshokouhi Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like things are ok, shall I submit it to this PR or open another one to remove the unused STATES?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do it here.

@dshokouhi
Copy link
Member Author

@MartinHjelmare ah yes those updated and added values for ACTION and ALERTS will be visible under the vacuum status attribute so they are indeed a breaking change for anyone relying on the data there.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when build passes and a breaking change paragraph is added in the PR description, for the release notes.

@balloob balloob merged commit 52074ee into home-assistant:dev Nov 6, 2018
@ghost ghost removed the in progress label Nov 6, 2018
@dshokouhi dshokouhi deleted the update_neato_states_actions_alerts branch November 6, 2018 20:33
@balloob balloob mentioned this pull request Nov 29, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants