New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Neato states, actions and alerts based on Neato docs #17353

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@dshokouhi
Contributor

dshokouhi commented Oct 12, 2018

Description:

Neato has updated their actions and alerts, this PR updates the integration to include those changes and also removes unused states: https://developers.neatorobotics.com/api/robot-remote-protocol/request-response-formats

Breaking Change:
The vacuum status attribute has new alerts and updated actions.

Related issue (if applicable): fixes # N/A

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io# N/A

Example entry for configuration.yaml (if applicable):

neato:
  username: username
  password: password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
@MartinHjelmare

Looks like changing the action values is a breaking change since it changes part of vacuum state attributes. Same for alerts. Is this correct?

@@ -32,6 +32,7 @@
}, extra=vol.ALLOW_EXTRA)
STATES = {

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Oct 20, 2018

Member

Where is this used? I can't find usage in any of the platforms.

This comment has been minimized.

@dshokouhi

dshokouhi Oct 20, 2018

Contributor

I just took a closer look, I don't think these STATES were ever used (not even imported). They were actually added in switch.neato when the component was first created. I will remove this and test it out before submitting a change.

This comment has been minimized.

@dshokouhi

dshokouhi Oct 20, 2018

Contributor

Looks like things are ok, shall I submit it to this PR or open another one to remove the unused STATES?

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Oct 20, 2018

Member

I think we can do it here.

@dshokouhi

This comment has been minimized.

Contributor

dshokouhi commented Oct 20, 2018

@MartinHjelmare ah yes those updated and added values for ACTION and ALERTS will be visible under the vacuum status attribute so they are indeed a breaking change for anyone relying on the data there.

@MartinHjelmare

Can be merged when build passes and a breaking change paragraph is added in the PR description, for the release notes.

@balloob balloob merged commit 52074ee into home-assistant:dev Nov 6, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 93.605%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

@dshokouhi dshokouhi deleted the dshokouhi:update_neato_states_actions_alerts branch Nov 6, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Update Neato states, actions and alerts based on Neato docs (home-ass…
…istant#17353)

* Update neato sstates actions and alerts based on neato docs

* Remove unused STATES

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment