New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Neato states, actions and alerts based on Neato docs #17353
Update Neato states, actions and alerts based on Neato docs #17353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like changing the action values is a breaking change since it changes part of vacuum state attributes. Same for alerts. Is this correct?
homeassistant/components/neato.py
Outdated
@@ -32,6 +32,7 @@ | |||
}, extra=vol.ALLOW_EXTRA) | |||
|
|||
STATES = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this used? I can't find usage in any of the platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just took a closer look, I don't think these STATES
were ever used (not even imported). They were actually added in switch.neato
when the component was first created. I will remove this and test it out before submitting a change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like things are ok, shall I submit it to this PR or open another one to remove the unused STATES
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do it here.
@MartinHjelmare ah yes those updated and added values for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged when build passes and a breaking change paragraph is added in the PR description, for the release notes.
Description:
Neato has updated their actions and alerts, this PR updates the integration to include those changes and also removes unused states: https://developers.neatorobotics.com/api/robot-remote-protocol/request-response-formats
Breaking Change:
The vacuum status attribute has new alerts and updated actions.
Related issue (if applicable): fixes # N/A
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io# N/A
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests pass