Add target temperature low high to MQTT climate #17391
Conversation
ghost
added
the
| self.hass, self._topic[CONF_TEMPERATURE_LOW_COMMAND_TOPIC], | ||
| kwargs.get(ATTR_TARGET_TEMP_LOW), self._qos, self._retain) | ||
| mqtt.async_publish( | ||
| self.hass, self._topic[CONF_TEMPERATURE_HIGH_COMMAND_TOPIC], |
There was a problem hiding this comment.
line too long (80 > 79 characters)
|
|
||
| if self._topic[CONF_TEMPERATURE_HIGH_STATE_TOPIC] is None: | ||
| # optimistic mode | ||
| self._target_high_temperature = kwargs.get(ATTR_TARGET_TEMP_HIGH) |
There was a problem hiding this comment.
line too long (81 > 79 characters)
| @@ -225,7 +247,8 @@ class MqttClimate(MqttAvailability, MqttDiscoveryUpdate, ClimateDevice): | |||
|
|
|||
| def __init__(self, hass, name, topic, value_templates, qos, retain, | |||
| mode_list, fan_mode_list, swing_mode_list, | |||
| target_temperature, away, hold, current_fan_mode, | |||
| target_temperature, target_temperature_low, target_temperature_high, | |||
There was a problem hiding this comment.
line too long (85 > 79 characters)
| @@ -91,6 +101,8 @@ | |||
| vol.Optional(CONF_POWER_STATE_TOPIC): mqtt.valid_subscribe_topic, | |||
| vol.Optional(CONF_MODE_STATE_TOPIC): mqtt.valid_subscribe_topic, | |||
| vol.Optional(CONF_TEMPERATURE_STATE_TOPIC): mqtt.valid_subscribe_topic, | |||
| vol.Optional(CONF_TEMPERATURE_LOW_STATE_TOPIC): mqtt.valid_subscribe_topic, | |||
| vol.Optional(CONF_TEMPERATURE_HIGH_STATE_TOPIC): mqtt.valid_subscribe_topic, | |||
There was a problem hiding this comment.
line too long (80 > 79 characters)
| @@ -82,6 +90,8 @@ | |||
| vol.Optional(CONF_POWER_COMMAND_TOPIC): mqtt.valid_publish_topic, | |||
| vol.Optional(CONF_MODE_COMMAND_TOPIC): mqtt.valid_publish_topic, | |||
| vol.Optional(CONF_TEMPERATURE_COMMAND_TOPIC): mqtt.valid_publish_topic, | |||
| vol.Optional(CONF_TEMPERATURE_LOW_COMMAND_TOPIC): mqtt.valid_publish_topic, | |||
| vol.Optional(CONF_TEMPERATURE_HIGH_COMMAND_TOPIC): mqtt.valid_publish_topic, | |||
There was a problem hiding this comment.
line too long (80 > 79 characters)
| vol.Optional(CONF_TEMPERATURE_LOW_STATE_TOPIC): | ||
| mqtt.valid_subscribe_topic, | ||
| vol.Optional(CONF_TEMPERATURE_HIGH_STATE_TOPIC): | ||
| mqtt.valid_subscribe_topic, |
There was a problem hiding this comment.
continuation line unaligned for hanging indent
There was a problem hiding this comment.
I'm not sure how else to indent these as otherwise the line will be too long.
| @@ -91,6 +101,10 @@ | |||
| vol.Optional(CONF_POWER_STATE_TOPIC): mqtt.valid_subscribe_topic, | |||
| vol.Optional(CONF_MODE_STATE_TOPIC): mqtt.valid_subscribe_topic, | |||
| vol.Optional(CONF_TEMPERATURE_STATE_TOPIC): mqtt.valid_subscribe_topic, | |||
| vol.Optional(CONF_TEMPERATURE_LOW_STATE_TOPIC): | |||
| mqtt.valid_subscribe_topic, | |||
There was a problem hiding this comment.
continuation line unaligned for hanging indent
| vol.Optional(CONF_TEMPERATURE_LOW_COMMAND_TOPIC): | ||
| mqtt.valid_publish_topic, | ||
| vol.Optional(CONF_TEMPERATURE_HIGH_COMMAND_TOPIC): | ||
| mqtt.valid_publish_topic, |
There was a problem hiding this comment.
continuation line unaligned for hanging indent
| @@ -82,6 +90,10 @@ | |||
| vol.Optional(CONF_POWER_COMMAND_TOPIC): mqtt.valid_publish_topic, | |||
| vol.Optional(CONF_MODE_COMMAND_TOPIC): mqtt.valid_publish_topic, | |||
| vol.Optional(CONF_TEMPERATURE_COMMAND_TOPIC): mqtt.valid_publish_topic, | |||
| vol.Optional(CONF_TEMPERATURE_LOW_COMMAND_TOPIC): | |||
| mqtt.valid_publish_topic, | |||
There was a problem hiding this comment.
continuation line unaligned for hanging indent
|
Wouldn't it make more sense to send it over 1 topic? That way it will always stay in sync. |
|
This PR seems to have gone stale. Closing it. |
|
@balloob What would be needed to move this forward? |
|
Sending over low and high in one mqtt topic might not work for all mqtt devices. With then broken out in home assisstant you have the possibility to use a value template to grab both from one mqtt topic. |
|
@rwagoner think we can get this opened back up? I could really use this in my setup. |
Description:
Add support for target low and high temperature setpoints in MQTT climate.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6739
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: