Support for Point component

[fredrike]

Description:

Adds support for the minut.com Point sensor/alarm.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7269

Example entry for configuration.yaml (if applicable): configuration.yaml

point:
    client_id: CLIENT_ID
    client_secret: CLIENT_SECRET  

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

Todo:

• Smoother authentication (does HA have a preferred way to handle components with OAuth2?).
• Integrate the new webhooks (where is the documentation/example code for this?)

[Kane610]

You should look at doing this integration through config entries.

[fredrike]

You should look at doing this integration through config entries.

@Kane610 Yes, I'm working on that.. I submitted this PR to get some suggestions on how to improve the integration.

I'll use this as inspiration of both the integration and the webhook part.

[fredrike]

We are required to support for:

• Handles internet unavailable. Log a warning once when unavailable, log once when reconnected.
• Handles device/service unavailable. Log a warning once when unavailable, log once when reconnected.

for the Silver Quality Scale, what is the recommended way of doing so? Is this enough?

[Kane610]

For logging? That should be enough. Maybe some kind of identifier if you can connect to multiple clients

Don't forget that you have to move your MinutPointClient to an external lib

[fredrike]

For logging? That should be enough. Maybe some kind of identifier if you can connect to multiple clients

Great!

What about SCAN_INTERVAL is there some example code I can look at on how it should be implemented or is this ok?
Or is it better to use track_time_interval(hass, self._sync, scan_interval)?

Don't forget that you have to move your MinutPointClient to an external lib

No I'm fully aware of that but have had so many changes that it's easier if everything is in the same place.

[Kane610]

scan interval is used like this: https://github.com/home-assistant/home-assistant/blob/6b3e4ca7bd167295e7984d2c00b2c4c5e748781a/homeassistant/components/switch/unifi.py#L24

[fredrike]

scan interval is used like this:

home-assistant/homeassistant/components/switch/unifi.py

Line 24 in 6b3e4ca

SCAN_INTERVAL = timedelta(seconds=15)

And how is that used (I can't find a documentation for this)? Only the platform needs to update as that updates all sensors..

[Kane610]

Sometimes you need to ask the code ;)

Somewhere in entity platform or something will use that parameter to set the update interval for that platform.

[Kane610]

Was looking for something else and found it.

https://github.com/home-assistant/home-assistant/blob/6b3e4ca7bd167295e7984d2c00b2c4c5e748781a/homeassistant/helpers/entity_component.py#L138

[fredrike]

@Kane610, I have a working configuration flow with authentication against minut.com now! Just a few questions:

• What do I need to do to get my devices (sensors) to show up under integrations?
• Do I have to make all translations or will it fall back to components/point/strings.json?
• I'm not super happy with the current authentication flow, I would like to redirect the user after entering API secrets and automatically show the success dialog when directed back. I.e., the second dialog below should be automatic.
• I'm using http.register_view() as below, is there a way to de-register the view after the user is authenticated (I read the code but couldn't find anything). https://github.com/home-assistant/home-assistant/blob/8c61b86dce33ea53f4fb0ad048c1b7c5687d22f5/homeassistant/components/point/config_flow.py#L111

[Kane610]

• You need to add https://github.com/home-assistant/home-assistant/blob/fc8af22191d054524c9e124a5fed7ebade32f16c/homeassistant/components/binary_sensor/deconz.py#L124
• you need to do one translation, preferably English, but Blekingska is good as well ;)
• You can redirect to different flows whenever you want, if I understood you correctly
• I've never used register view so I can't help you there, but can't you just set the object to None?

[fredrike]

@MartinHjelmare is my changes ok or are there more things that I need to fix?

What is the timeframe for 0.82.1?

[MartinHjelmare]

I think this looks good, but I'd like to read the tests before I approve.

This will not go out before 0.83 since it's a new feature.

[MartinHjelmare]

Looks good! @balloob?

[balloob]

I trust Martin :)

Martin says it's ok

[balloob]

Beta hasn't been cut so it's part of 82.

[MartinHjelmare]

I think that was a typo: 0.82 -> 0.83

[fredrike]

@MartinHjelmare & @balloob, Thank you for your comments and improvements for enabling this. I really evaluate the code quality that you are striving for.