Météo-france sensor : current weather and 1 hour rain forecast #17773

victorcerutti · 2018-10-24T20:27:31Z

Description:

Météo France provides a convenient rain forecast that is pretty accurate.
This sensor gives the time to next rain forecasted.
It also display several sensor for monitored conditions, as in the example
@MartinHjelmare @fabaff : I screwed up my last PR during a rebase. I took account of your requests and this is a new release of the Météo-France platform, using a pypi package

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
home-assistant/home-assistant.io#6938

Example entry for `configuration.yaml`

sensor:
  - platform: meteo_france
    postal_code: 76000
    monitored_conditions:
      - rain_chance
      - freeze_chance
      - thunder_chance
      - snow_chance
      - weather
      - next_rain
      - wind_speed
      - temperature
      - uv

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

…-france

Now work with pypi package and monitored conditions

fabaff · 2018-10-24T20:30:55Z

Successor of #17602.

MartinHjelmare · 2018-10-25T15:47:42Z

homeassistant/components/sensor/meteo_france.py

+Support for Meteo France raining forecast.
+
+For more details about this platform, please refer to the documentation at
+https://home-assistant.io/components/sensor.meteofrance/


There's a missing underscore in the page name.

homeassistant/components/sensor/meteo_france.py

MartinHjelmare · 2018-10-25T15:49:57Z

homeassistant/components/sensor/meteo_france.py

+
+PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
+    vol.Required(CONF_POSTAL_CODE): cv.string,
+    vol.Required(CONF_MONITORED_CONDITIONS, default=[]):


Default isn't necessary if key is required.

MartinHjelmare · 2018-10-25T15:50:29Z

homeassistant/components/sensor/meteo_france.py

+})
+
+
+def setup_platform(hass, config, add_devices, discovery_info=None):


Rename add_devices to add_entities.

MartinHjelmare · 2018-10-25T15:50:57Z

homeassistant/components/sensor/meteo_france.py

+
+def setup_platform(hass, config, add_devices, discovery_info=None):
+    """Set up the Meteo-France sensor."""
+    postal_code = config.get(CONF_POSTAL_CODE)


Use dict[key] for required config keys.

MartinHjelmare · 2018-10-25T15:52:22Z

homeassistant/components/sensor/meteo_france.py

+    @property
+    def name(self):
+        """Return the name of the sensor."""
+        return self._data["name"]+' '+SENSOR_TYPES[self._condition][0]


Use new style string formatting instead of string concatenation.

MartinHjelmare · 2018-10-25T15:52:52Z

homeassistant/components/sensor/meteo_france.py

+        """Return the state of the sensor."""
+        if self._data[self._condition] is not False:
+            return self._data[self._condition]
+        return STATE_UNKNOWN


Use None to represent unknown state.

MartinHjelmare · 2018-10-25T15:53:25Z

homeassistant/components/sensor/meteo_france.py

+        return STATE_UNKNOWN
+
+    @property
+    def state_attributes(self):


Replace this with device_state_attributes.

MartinHjelmare · 2018-10-25T15:53:39Z

homeassistant/components/sensor/meteo_france.py

+
+    @property
+    def state_attributes(self):
+        """Return the state attributes of the sun."""


Stale docstring.

houndci-bot · 2018-10-25T21:53:38Z

homeassistant/components/sensor/meteo_france.py

+                    }
+                }
+            except KeyError:
+                _LOGGER.error("No result for the monitored condition `{}`".format(self._condition))


line too long (99 > 79 characters)

houndci-bot · 2018-10-25T21:53:38Z

homeassistant/components/sensor/meteo_france.py

+        try:
+            return self._data[self._condition]
+        except KeyError:
+            _LOGGER.error("No result for the monitored condition `{}`".format(self._condition))


line too long (95 > 79 characters)

MartinHjelmare · 2018-10-25T22:30:00Z

homeassistant/components/sensor/meteo_france.py

+        try:
+            return self._data[self._condition]
+        except KeyError:
+            _LOGGER.error("No result for the condition `%s`", self._condition)


Please don't log in entity properties. We don't want any side effects here.

Thanks for the review.
Some cities doesn't have all the conditions returned by the package. What should I do about the sensor then ?
Without the exception catching, it fails, generates an error and the sensor is not displayed on the front-end.
I can also keep the exception catching without logging. Sensors stay on the front-end with a None value and it's up to the user to remove the monitored-condition that is not available for this location. But without error logging, there is not hint that it's the problem

Maybe another solution would be to still catch those KeyError and set the state as "no data available for this location".

Just move the access and exception handling etc to update and save the state in an instance attribute. Return the instance attribute here in the state property.

latest commit should fix this

MartinHjelmare · 2018-10-25T22:30:30Z

homeassistant/components/sensor/meteo_france.py

+                    }
+                }
+            except KeyError:
+                _LOGGER.error("No result for the condition `%s`",


This isn't resolved.

Errors are now catched at sensor initialization and state is set when updating the data

MartinHjelmare · 2018-10-26T19:41:58Z

homeassistant/components/sensor/meteo_france.py

+        self._data = client.get_data()
+        self._state = None
+        try:
+            self._state = self._data[self._condition]


Instead call add_entities with second argument True. It will make sure that update is called during entity addition.

We don't want side effects in init either.

MartinHjelmare · 2018-10-26T19:44:47Z

homeassistant/components/sensor/meteo_france.py

+        """Initialize the sensor."""
+        self._condition = condition
+        self._client = client
+        self._data = client.get_data()


Why are we only calling this here, one time? Shouldn't this be called on every update?

We should probably move this to update.

I'm new to Python but here is my understanding :
As client.get_data returns a dict, it passes the reference to the client data
When it's updated after the remote fetch/parsing of the package, the sensor _data is up to date.

I updated to call get_data() after the update to be sure the reference is never broken for whatever reason may happen

houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

MartinHjelmare

Looks good!

MartinHjelmare · 2018-10-29T13:55:24Z

@fabaff ok with you?

fabaff

Fine with me 🐦

romquenin · 2019-01-10T11:30:36Z

Hello, I would love to use this sensor for it's french human-readable text summary of the current conditions but unfortunately my foreign city is not available. Could it be possible to add a european city with it postal code (previsions-meteo-monde/londres/03772) 03772 for london.
It would be a great feature for French People living abroad.
Thanks.

MartinHjelmare · 2019-01-10T11:40:32Z

If you want to suggest an enhancement please open a feature request in the Feature Requests section of our community forum.

Merged PRs should not be used for enhancement discussion.

Thanks!

victorcerutti added 13 commits October 24, 2018 22:11

🌧 Meteo France rain forecast

9f4de72

do not fail on wrong config

6d989f5

Update name of sensor class

8fac1ca

do not show sensor if not working

35d0cbb

Update .coveragerc

7fc1dfe

ability to submit insee location code without final 0 needed by meteo…

7114054

…-france

Lynting

addc129

more lynting

7cd4250

update comment

403c129

block comment linting

f77268a

reducing length of long lines

4748034

linting

38839f3

Update météo-france platform

ce3e0fd

Now work with pypi package and monitored conditions

homeassistant added cla-signed new-platform platform: sensor.meteo_france labels Oct 24, 2018

ghost added the in progress label Oct 24, 2018

remove error log

a166cb0

victorcerutti mentioned this pull request Oct 24, 2018

Documentation for Météo France sensor home-assistant/home-assistant.io#6938

Merged

2 tasks

bachya added the Hacktoberfest label Oct 24, 2018

victorcerutti added 2 commits October 25, 2018 09:15

Update requirements_all.txt

ef131e8

Increase scan interval to 5 minutes

876b605

MartinHjelmare reviewed Oct 25, 2018

View reviewed changes

victorcerutti added 2 commits October 25, 2018 23:45

Update meteo_france according to review

1da1179

better error handling of location missing some monitored conditions

d23aade

houndci-bot reviewed Oct 25, 2018

View reviewed changes

fix lint error

f6a8a86

MartinHjelmare reviewed Oct 25, 2018

View reviewed changes

moving error log

06cd658

Errors are now catched at sensor initialization and state is set when updating the data

MartinHjelmare reviewed Oct 26, 2018

View reviewed changes

Update updating of sensor

3d395ef

houndci-bot reviewed Oct 29, 2018

View reviewed changes

MartinHjelmare approved these changes Oct 29, 2018

View reviewed changes

fabaff approved these changes Oct 29, 2018

View reviewed changes

fabaff merged commit cb73a8b into home-assistant:dev Oct 29, 2018

ghost removed the in progress label Oct 29, 2018

balloob mentioned this pull request Nov 9, 2018

0.82 #18335

Merged

adamotte mentioned this pull request Nov 11, 2018

New meteo_france sensor not working #18375

Closed

fabaff mentioned this pull request Nov 19, 2018

Limit meteorological data to weather platforms home-assistant/architecture#107

Closed

home-assistant locked as resolved and limited conversation to collaborators Jan 10, 2019

ghost added integration: meteo_france and removed platform: sensor.meteo_france labels Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Météo-france sensor : current weather and 1 hour rain forecast #17773

Météo-france sensor : current weather and 1 hour rain forecast #17773

victorcerutti commented Oct 24, 2018 •

edited

fabaff commented Oct 24, 2018

MartinHjelmare Oct 25, 2018

MartinHjelmare Oct 25, 2018

MartinHjelmare Oct 25, 2018

MartinHjelmare Oct 25, 2018

MartinHjelmare Oct 25, 2018

MartinHjelmare Oct 25, 2018

MartinHjelmare Oct 25, 2018

MartinHjelmare Oct 25, 2018

houndci-bot Oct 25, 2018

houndci-bot Oct 25, 2018

MartinHjelmare Oct 25, 2018

victorcerutti Oct 26, 2018

MartinHjelmare Oct 26, 2018 •

edited

victorcerutti Oct 26, 2018

MartinHjelmare Oct 25, 2018

MartinHjelmare Oct 26, 2018

MartinHjelmare Oct 26, 2018

MartinHjelmare Oct 26, 2018

victorcerutti Oct 29, 2018

houndci-bot left a comment

MartinHjelmare left a comment

MartinHjelmare commented Oct 29, 2018

fabaff left a comment

romquenin commented Jan 10, 2019

MartinHjelmare commented Jan 10, 2019

		})


		def setup_platform(hass, config, add_devices, discovery_info=None):

Météo-france sensor : current weather and 1 hour rain forecast #17773

Météo-france sensor : current weather and 1 hour rain forecast #17773

Conversation

victorcerutti commented Oct 24, 2018 • edited

Description:

Example entry for configuration.yaml

Checklist:

fabaff commented Oct 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MartinHjelmare Oct 26, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

MartinHjelmare left a comment

Choose a reason for hiding this comment

MartinHjelmare commented Oct 29, 2018

fabaff left a comment

Choose a reason for hiding this comment

romquenin commented Jan 10, 2019

MartinHjelmare commented Jan 10, 2019

victorcerutti commented Oct 24, 2018 •

edited

Example entry for `configuration.yaml`

MartinHjelmare Oct 26, 2018 •

edited