New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping aioasuswrt version #17814

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
6 participants
@kennedyshead
Contributor

kennedyshead commented Oct 26, 2018

Description:

There was a bug in Telnet connection in the old version.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
@fabaff

fabaff approved these changes Oct 26, 2018

Thanks 🐦

Don't forget to rebase #17757 after this PR has been merged.

@kennedyshead

This comment has been minimized.

Contributor

kennedyshead commented Oct 26, 2018

@fabaff will do 👍

@fabaff fabaff merged commit 92bad45 into home-assistant:dev Oct 26, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.238%
Details

@wafflebot wafflebot bot removed the in progress label Oct 26, 2018

@inverse

This comment has been minimized.

inverse commented Oct 30, 2018

Did this break the component? Since upgrading it's not working for me.

2018-10-30 20:14:45 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform asuswrt
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/device_tracker/__init__.py", line 174, in async_setup_platform
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/device_tracker/asuswrt.py", line 46, in async_get_scanner
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/device_tracker/asuswrt.py", line 71, in async_connect
@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Oct 30, 2018

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@inverse

This comment has been minimized.

inverse commented Oct 31, 2018

Okays - already done.

@kennedyshead kennedyshead deleted the kennedyshead:bumping_aioasuswrt_version branch Oct 31, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment