Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping aioasuswrt version #17814

Merged
merged 1 commit into from Oct 26, 2018
Merged

Bumping aioasuswrt version #17814

merged 1 commit into from Oct 26, 2018

Conversation

kennedyshead
Copy link
Contributor

Description:

There was a bug in Telnet connection in the old version.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@ghost ghost added the in progress label Oct 26, 2018
fabaff
fabaff approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

Don't forget to rebase #17757 after this PR has been merged.

@kennedyshead
Copy link
Contributor Author

@fabaff will do 👍

@fabaff fabaff merged commit 92bad45 into home-assistant:dev Oct 26, 2018
@ghost ghost removed the in progress label Oct 26, 2018
@inverse
Copy link
Contributor

inverse commented Oct 30, 2018 •
edited

Did this break the component? Since upgrading it's not working for me.

2018-10-30 20:14:45 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform asuswrt
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/device_tracker/__init__.py", line 174, in async_setup_platform
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/device_tracker/asuswrt.py", line 46, in async_get_scanner
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/device_tracker/asuswrt.py", line 71, in async_connect

@MartinHjelmare
Copy link
Member

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@inverse
Copy link
Contributor

inverse commented Oct 31, 2018

Okays - already done.

@kennedyshead kennedyshead deleted the bumping_aioasuswrt_version branch October 31, 2018 07:49
@jimbob1001 jimbob1001 mentioned this pull request Nov 8, 2018
Closed
@balloob balloob mentioned this pull request Nov 9, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
cla-signed core Hacktoberfest integration: device_tracker small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kennedyshead @inverse @MartinHjelmare @fabaff @homeassistant @MagnusKnutas