Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR builds on the updated version sensor (#18067). It improves validation and adds a name that makes sense with the new functionality.
Currently it always shows 'Current Version' as name, which is confusing when using the component to check the latest version available.
I think this is not a breaking change, but maybe someone can verify (@ludeeus reminded me the entity_id is linked to the name):
Edit: this now also sets the icon property which was forgotten
Related issue (if applicable): fixes # NA
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7409
should be cherry-picked for the beta 0.82 release
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: