New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress PyNaCl warnings of Discord notify #18385

Merged
merged 2 commits into from Nov 11, 2018

Conversation

Projects
None yet
4 participants
@sqldiablo
Contributor

sqldiablo commented Nov 11, 2018

Description:

Suppress PyNaCl warnings, since we're not using the voice features of the discord.py package. Correct variable used before it is assigned error for the images variable.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
Discord - Bugfixes
Suppress PyNaCl warnings, since we're not using the voice features of the discord.py package.

Correct variable used before it is assigned error for the images variable.

@sqldiablo sqldiablo changed the title from Discord - Bugfixes to Discord - Minor bugfixes Nov 11, 2018

@fabaff

fabaff approved these changes Nov 11, 2018

Thanks 🐦

@fabaff fabaff changed the title from Discord - Minor bugfixes to Suppress PyNaCl warnings of Discord notify Nov 11, 2018

@fabaff fabaff merged commit ca86755 into home-assistant:dev Nov 11, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.038%
Details

@wafflebot wafflebot bot removed the in progress label Nov 11, 2018

@sqldiablo sqldiablo deleted the sqldiablo:discord branch Nov 11, 2018

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Nov 12, 2018

Discord - Minor bugfixes (home-assistant#18385)
Suppress PyNaCl warnings of Discord notify

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Nov 12, 2018

Discord - Minor bugfixes (home-assistant#18385)
Suppress PyNaCl warnings of Discord notify

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Discord - Minor bugfixes (home-assistant#18385)
Suppress PyNaCl warnings of Discord notify

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment