Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pynello to 2.0.2 #18402

Merged
merged 3 commits into from Nov 12, 2018
Merged

Update pynello to 2.0.2 #18402

merged 3 commits into from Nov 12, 2018

Conversation

ultrara1n
Copy link
Contributor

Description:

There was an update some time ago for the package, introducing the public api and marking the private as deprecated.

I had a look at the new public api and there are some things to figure out before changing.
The main differences are:

  • using of client_id, so you account doesn't get blocked if you are using it in HA
  • short_id was removed
  • activity was removed
    • worst thing, you are not able to identify a ringing bell easy as before

As long as the private api is still working, we should leave it there. Maybe they will add recent activity in the future.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@cgarwood cgarwood merged commit e5930da into home-assistant:dev Nov 12, 2018
@ghost ghost removed the in progress label Nov 12, 2018
@balloob balloob mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants