New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Météo-France platform for the weather component #18404
Météo-France platform for the weather component #18404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glance looks the rest pretty solid.
Please consider my last commit as a work in progress. meteo_france:
- postal_code: 29000
monitored_conditions:
- rain_chance
- freeze_chance
- thunder_chance
- snow_chance
- weather
- next_rain
- wind_speed
- temperature
- uv
weather_card: false
- postal_code: 76000
monitored_conditions:
- temperature
- postal_code: 51100 For each component, we display by default a weather card (unless config says otherwise) and a sensor for each monitored conditions (optional) All the logic of client and update is managed by the If this is correct, I will continue in this direction and update the documentation to reflect this changes |
@fabaff Can you please review the way the config is set for this component ? |
b994ce1
to
f46ddaa
Compare
Hello, Many thanks for considering my request ! |
We should not have a weather card config option, it's up to the user with Lovelace to decide if they want to show a weather card for an entity or not. The config seems fine. |
Thank you for the feedback |
Changing conf name to something more universal for worldwide weather forecast (postal code was only relevent for France)
f46ddaa
to
9f741c5
Compare
I think this is all good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Can be merged when build passes. |
Dear @fabaff @mxworm , Do you know in which version this component will be available? Best regards, |
0.89 |
This is reopening of #18322 after I removed the weather model change I made.
Discussions about enhancing the weather component (model and frontend) have been posted to :
Description:
After the recently merged Météo-France sensor providing weather datas from Météo-France, here is the
weather
componentThe configuration is similar to the weather sensor and the weather platform also provides a 4 days forecast.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7480
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.