Modbus write_register accept integer and list #18425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated voluptuous schema to accept integer and list. That way the correct function code modbus function code is called (0x06 for integer (single register), 0x10 for list (multiple registers)).
homeassistant
added
cla-needed
integration: modbus
small-pr
ghost
added
the
houndci-bot
reviewed
Nov 13, 2018
homeassistant/components/modbus.py
Outdated
| @@ -60,7 +60,7 @@ | |||
| SERVICE_WRITE_REGISTER_SCHEMA = vol.Schema({ | |||
| vol.Required(ATTR_UNIT): cv.positive_int, | |||
| vol.Required(ATTR_ADDRESS): cv.positive_int, | |||
| vol.Required(ATTR_VALUE): vol.All(cv.ensure_list, [cv.positive_int]) | |||
| vol.Required(ATTR_VALUE): vol.Any(cv.positive_int, vol.All(cv.ensure_list, [cv.positive_int])) | |||
There was a problem hiding this comment.
line too long (98 > 79 characters)
houndci-bot
reviewed
Nov 13, 2018
homeassistant/components/modbus.py
Outdated
| @@ -60,7 +60,9 @@ | |||
| SERVICE_WRITE_REGISTER_SCHEMA = vol.Schema({ | |||
| vol.Required(ATTR_UNIT): cv.positive_int, | |||
| vol.Required(ATTR_ADDRESS): cv.positive_int, | |||
| vol.Required(ATTR_VALUE): vol.All(cv.ensure_list, [cv.positive_int]) | |||
| vol.Required(ATTR_VALUE): vol.Any( | |||
| cv.positive_int, | |||
|
Could not find a related documentation PR, adding |
|
Besides documentation also requires an update to |
|
This PR seems to have gone stale. Closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated voluptuous schema to accept integer and list. That way the correct function code modbus function code is called (0x06 for integer (single register), 0x10 for list (multiple registers)).
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass