New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avg price for tibber sensor #18426

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
4 participants
@Danielhiversen
Member

Danielhiversen commented Nov 13, 2018

Description:

Avg price for tibber sensor

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@MartinHjelmare

Looks good!

@Danielhiversen Danielhiversen merged commit 7aa41d6 into dev Nov 13, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.039%
Details

@Danielhiversen Danielhiversen deleted the tibber_avg_price branch Nov 13, 2018

@wafflebot wafflebot bot removed the in progress label Nov 13, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

@hulkhaugen

This comment has been minimized.

hulkhaugen commented Nov 29, 2018

Is it possible to round down to only 3 decimals without setting up a template sensor?

@Danielhiversen

This comment has been minimized.

Member

Danielhiversen commented Nov 29, 2018

I can add a round to the code.

@home-assistant home-assistant locked and limited conversation to collaborators Nov 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.