New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the Harman Kardon AVR #18471
Support for the Harman Kardon AVR #18471
Conversation
94c8815
to
58ba32b
Compare
…ssistant into mediaplayer_hk-avr # Conflicts: # homeassistant/components/media_player/harman_kardon_avr.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes left, otherwise looks good! @fabaff?
…into mediaplayer_hk-avr # Conflicts: # requirements_all.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@MartinHjelmare how can I make sure that this platform is merged as soon as possible? Is there something else I need to do? Or is it just waiting untill someone with authorization merges the pull request? |
* Feature: support for the HK AVR * Remove testcode * Feature: support for the HK AVR * Remove testcode * Added checklist * Review fixes whitespaces * Lint fixes * Review fixes, add current source * Remove unused imports * Review fixes; State constants, dict[key] * More review fixes, Unknown state and Sources * Review fix; rename devices to entities
Description:
Support the Harman Kardon AVR as media players
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
See #7581
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: