New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the Harman Kardon AVR #18471

Merged
merged 15 commits into from Dec 13, 2018

Conversation

Projects
None yet
5 participants
@Devqon
Copy link
Contributor

Devqon commented Nov 14, 2018

Description:

Support the Harman Kardon AVR as media players

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: harman_kardon_avr
    host: 192.168.178.168

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

See #7581

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • [N/A] Tests have been added to verify that the new code works.

Devqon added some commits Nov 14, 2018

@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Nov 14, 2018

Hi @Devqon,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 14, 2018

Devqon added some commits Nov 14, 2018

@Devqon Devqon force-pushed the Devqon:mediaplayer_hk-avr branch from 94c8815 to 58ba32b Nov 19, 2018

@Devqon Devqon changed the title [WIP]: Feature: support for the Harman Kardon AVR WIP: Feature: support for the Harman Kardon AVR Nov 19, 2018

@Devqon Devqon referenced this pull request Nov 19, 2018

Merged

Documentation for the Harman Kardon media player #7581

2 of 2 tasks complete

@Devqon Devqon changed the title WIP: Feature: support for the Harman Kardon AVR Feature: support for the Harman Kardon AVR Nov 19, 2018

@fabaff fabaff changed the title Feature: support for the Harman Kardon AVR Support for the Harman Kardon AVR Nov 25, 2018

Devqon added some commits Nov 26, 2018

Merge branch 'mediaplayer_hk-avr' of https://github.com/Devqon/home-a…
…ssistant into mediaplayer_hk-avr

# Conflicts:
#	homeassistant/components/media_player/harman_kardon_avr.py
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Two small changes left, otherwise looks good! @fabaff?

Devqon added some commits Dec 3, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into mediaplayer_hk-avr

# Conflicts:
#	requirements_all.txt
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good!

@Devqon

This comment has been minimized.

Copy link
Contributor

Devqon commented Dec 13, 2018

@MartinHjelmare how can I make sure that this platform is merged as soon as possible? Is there something else I need to do? Or is it just waiting untill someone with authorization merges the pull request?

@MartinHjelmare MartinHjelmare merged commit 0fa7186 into home-assistant:dev Dec 13, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.927%
Details

@wafflebot wafflebot bot removed the in progress label Dec 13, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Support for the Harman Kardon AVR (home-assistant#18471)
* Feature: support for the HK AVR

* Remove testcode

* Feature: support for the HK AVR

* Remove testcode

* Added checklist

* Review fixes whitespaces

* Lint fixes

* Review fixes, add current source

* Remove unused imports

* Review fixes; State constants, dict[key]

* More review fixes, Unknown state and Sources

* Review fix; rename devices to entities

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment