New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template binary sensor to not track all state changes #18573

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
3 participants
@amelchio
Member

amelchio commented Nov 19, 2018

Breaking change:

Template binary sensors for which we could not determine what states to track to re-render will now only be updated when manually refreshed using the homeassistant.update_entity service.

Description:

More or less a copy+paste of #17276 and #17319, but for binary_sensor. I did have to introduce async_update() to enable forced updates.

Also updates the tests with async/await syntax.

Related issue (if applicable): home-assistant/architecture#85

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

binary_sensor:
  platform: template
  sensors:
    static:
      value_template: '{{ "true" }}'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob merged commit 84fd66c into home-assistant:dev Nov 19, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 93.038%
Details

@wafflebot wafflebot bot removed the in progress label Nov 19, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 19, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant:
  Bumped ghlocalapi to 0.1.0 (home-assistant#18584)
  Prefix all xiaomi_aqara events (home-assistant#17354)
  Fix MQTT async_added_to_hass (home-assistant#18575)
  Add mikrotik SSL support (home-assistant#17898)
  Reconfigure MQTT binary_sensor component if discovery info is changed (home-assistant#18169)
  Darksky: Expose missing conditions for day 0 forecast (home-assistant#18312)
  Update pyhomematic to 0.1.52 and add features for lights (home-assistant#18499)
  Fix for epson state not updating (home-assistant#18357)
  Support for Point component (home-assistant#17466)
  Template binary sensor to not track all state changes (home-assistant#18573)
  Correct cached stale device tracker handling (home-assistant#18572)
  Add support for sessions (home-assistant#18518)
  Remove turn_on and turn_off feature for clients (home-assistant#18234)
  Log delay and wait_template steps in scripts (home-assistant#18448)
  Logbook speedup (home-assistant#18376)
  Avoid race in entity_platform.async_add_entities() (home-assistant#18445)
  Fix small issue related to topic prefix (home-assistant#18512)
  Enable native support + ADB authentication for Fire TV (home-assistant#17767)
  Re-adding the season attribute (home-assistant#18523)

@amelchio amelchio referenced this pull request Nov 19, 2018

Merged

Cleanup descriptions for template sensor/binary_sensor #7585

2 of 2 tasks complete

@amelchio amelchio removed their assignment Nov 19, 2018

@amelchio

This comment has been minimized.

Member

amelchio commented Nov 21, 2018

Added breaking change label (and note).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment