Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template binary sensor to not track all state changes #18573

Merged
merged 1 commit into from Nov 19, 2018

Conversation

amelchio
Copy link
Contributor

@amelchio amelchio commented Nov 19, 2018

Breaking change:

Template binary sensors for which we could not determine what states to track to re-render will now only be updated when manually refreshed using the homeassistant.update_entity service.

Description:

More or less a copy+paste of #17276 and #17319, but for binary_sensor. I did have to introduce async_update() to enable forced updates.

Also updates the tests with async/await syntax.

Related issue (if applicable): home-assistant/architecture#85

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

binary_sensor:
  platform: template
  sensors:
    static:
      value_template: '{{ "true" }}'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob merged commit 84fd66c into home-assistant:dev Nov 19, 2018
@ghost ghost removed the in progress label Nov 19, 2018
@amelchio amelchio removed their assignment Nov 19, 2018
@amelchio
Copy link
Contributor Author

Added breaking change label (and note).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants