Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MQTT async_added_to_hass #18575

Merged
merged 2 commits into from Nov 19, 2018
Merged

Fix MQTT async_added_to_hass #18575

merged 2 commits into from Nov 19, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Nov 19, 2018

Description:

We were not calling async_added_to_hass correctly. It would return a coroutine but with a hackish approach in one and the other was just broken.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned balloob Nov 19, 2018
@ghost ghost added the in progress label Nov 19, 2018
@balloob balloob changed the title Fix some bad invocations Fix MQTT async_added_to_hass Nov 19, 2018
@pvizeli pvizeli merged commit f86083c into dev Nov 19, 2018
@ghost ghost removed the in progress label Nov 19, 2018
@balloob balloob mentioned this pull request Nov 29, 2018
@fabaff fabaff deleted the fix-async-added-to-hass branch March 17, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants