Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper signals #18613

Merged
merged 6 commits into from Nov 21, 2018

Conversation

@balloob
Copy link
Member

commented Nov 21, 2018

Description:

We finally were using the aiohttp signals correctly since 3.4.4, we can move the work around now.

We were also using a deprecated way of running a HTTP server in emulated Hue.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Nov 21, 2018

@ghost ghost assigned balloob Nov 21, 2018

@ghost ghost added the in progress label Nov 21, 2018

@balloob balloob force-pushed the use-proper-signals branch from d612580 to a6dd0fc Nov 21, 2018

balloob added some commits Nov 21, 2018

Update homeassistant/components/http/ban.py
Co-Authored-By: balloob <paulus@home-assistant.io>
@balloob

This comment has been minimized.

Copy link
Member Author

commented Nov 21, 2018

For the IP ban, the proper solution would be for it to be migrated to the storage helper.

@balloob

This comment has been minimized.

Copy link
Member Author

commented Nov 21, 2018

I also realized that auth being a middleware means it's also being run for static resource requests 🤷‍♂️ I guess in a perfect world NGINX would sit in front of the static endpoint and serve that.

@balloob balloob merged commit 1341ecd into dev Nov 21, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.019%
Details

@ghost ghost removed the in progress label Nov 21, 2018

@balloob balloob deleted the use-proper-signals branch Nov 21, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 22, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant:
  Cleanup BOM dependencies + add basic test + IDEA autoformat (home-assistant#18462)
  Minor change to still image on mjpeg (home-assistant#18602)
  Add /sbin to launchd PATH (home-assistant#18601)
  Use proper signals (home-assistant#18613)
  Bump to 0.84.0.dev0
  Updated frontend to 20181121.0
  Update translations

balloob added a commit that referenced this pull request Nov 29, 2018

Use proper signals (#18613)
* Emulated Hue not use deprecated handler

* Remove no longer needed workaround

* Add middleware directly

* Dont always load the ban config file

* Update homeassistant/components/http/ban.py

Co-Authored-By: balloob <paulus@home-assistant.io>

* Update __init__.py

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83.1 #18811

@balloob balloob added this to the 0.83.1 milestone Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.