New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert shopping-list update to WebSockets #18713

Merged
merged 3 commits into from Nov 26, 2018

Conversation

Projects
None yet
3 participants
@iantrich
Contributor

iantrich commented Nov 26, 2018

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
msg_id, item))
except KeyError:
connection.send_message(websocket_api.error_message(
msg_id, 'shopping_list_update_failed', 'Item not found'))

This comment has been minimized.

@balloob

balloob Nov 26, 2018

Member
Suggested change Beta
msg_id, 'shopping_list_update_failed', 'Item not found'))
msg_id, 'item_not_found', 'Item not found'))
assert msg['success'] is False
data = msg['error']
assert data == {
'code': 'shopping_list_update_failed',

This comment has been minimized.

@balloob

balloob Nov 26, 2018

Member
Suggested change Beta
'code': 'shopping_list_update_failed',
'code': 'item_not_found',

@balloob balloob merged commit b5b5bc2 into home-assistant:dev Nov 26, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 93.01%
Details

@wafflebot wafflebot bot removed the in progress label Nov 26, 2018

@balloob balloob added this to the 0.83.1 milestone Nov 29, 2018

balloob added a commit that referenced this pull request Nov 29, 2018

Convert shopping-list update to WebSockets (#18713)
* Convert shopping-list update to WebSockets

* Update shopping_list.py

* Update test_shopping_list.py

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83.1 #18811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment