Optionally do not log template rendering errors #18724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
houndci-bot
reviewed
Nov 26, 2018
emontnemery
force-pushed
the
template_ignore_errors
branch
from
0233418
to
2ca8547
Compare
emontnemery
force-pushed
the
template_ignore_errors
branch
from
2ca8547
to
b5b0ce1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Unlike
async_render,async_render_with_possible_json_valueprints an angry error message if the template could not be rendered.This PR disables logging if
error_value(default value in case the template can't be rendered) has been set.Checklist:
tox. Your PR cannot be merged unless tests pass