New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logbook domain filter - alexa, homekit #18790

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@cdce8p
Member

cdce8p commented Nov 29, 2018

Description:

Also the logbook does support the include / exlude filter, this didn't work for homekit and alexa events. Since they have their own event_type. This PR fixes that.

However, due to the nature of those to components, only the domain filter is supported.

Related issue: https://community.home-assistant.io/t/homekit-logbook-entries/81554

Example entry for configuration.yaml (if applicable):

logbook:
  exclude:   # or include
    domains:
      - alexa
      - homekit

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@cdce8p cdce8p added this to the 0.83.1 milestone Nov 29, 2018

@wafflebot wafflebot bot added the in progress label Nov 29, 2018

@balloob balloob merged commit 474567e into home-assistant:dev Nov 29, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 92.916%
Details

@wafflebot wafflebot bot removed the in progress label Nov 29, 2018

@cdce8p cdce8p deleted the cdce8p:fix-logbook-domain-filter branch Nov 29, 2018

balloob added a commit that referenced this pull request Nov 29, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83.1 #18811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment