Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logbook domain filter - alexa, homekit #18790

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Fix logbook domain filter - alexa, homekit #18790

merged 1 commit into from
Nov 29, 2018

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Nov 29, 2018

Description:

Also the logbook does support the include / exlude filter, this didn't work for homekit and alexa events. Since they have their own event_type. This PR fixes that.

However, due to the nature of those to components, only the domain filter is supported.

Related issue: https://community.home-assistant.io/t/homekit-logbook-entries/81554

Example entry for configuration.yaml (if applicable):

logbook:
  exclude:   # or include
    domains:
      - alexa
      - homekit

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@cdce8p cdce8p added this to the 0.83.1 milestone Nov 29, 2018
@ghost ghost assigned cdce8p Nov 29, 2018
@ghost ghost added the in progress label Nov 29, 2018
@balloob balloob merged commit 474567e into home-assistant:dev Nov 29, 2018
@ghost ghost removed the in progress label Nov 29, 2018
@cdce8p cdce8p deleted the fix-logbook-domain-filter branch November 29, 2018 19:57
@balloob balloob mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants