New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auth backwards compat again #18792

Merged
merged 2 commits into from Nov 29, 2018

Conversation

Projects
None yet
2 participants
@balloob
Member

balloob commented Nov 29, 2018

Description:

This makes the auth storage backwards compatible with 0.82 and before so people can rollback.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.83.1 milestone Nov 29, 2018

@wafflebot wafflebot bot added the in progress label Nov 29, 2018

@balloob balloob changed the title from Made auth not backwards compat to Make auth backwards compat again Nov 29, 2018

@balloob balloob merged commit 28215d7 into dev Nov 29, 2018

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA

@delete-merged-branch delete-merged-branch bot deleted the make-auth-backwards-compat branch Nov 29, 2018

@wafflebot wafflebot bot removed the in progress label Nov 29, 2018

balloob added a commit that referenced this pull request Nov 29, 2018

Make auth backwards compat again (#18792)
* Made auth not backwards compat

* Fix tests

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83.1 #18811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment