Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automation log error #18965

Merged
merged 1 commit into from Dec 13, 2018
Merged

Automation log error #18965

merged 1 commit into from Dec 13, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Dec 3, 2018 •
edited

Description:

Requires #18962 to be merged

Automation component will now log any error raised from executing the script.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner December 3, 2018 14:06
@ghost ghost assigned balloob Dec 3, 2018
@ghost ghost added the in progress label Dec 3, 2018
@balloob balloob mentioned this pull request Dec 3, 2018
Merged
4 tasks
@balloob balloob merged commit 9d9e113 into dev Dec 13, 2018
@ghost ghost removed the in progress label Dec 13, 2018
@delete-merged-branch delete-merged-branch bot deleted the automation-log-error branch December 13, 2018 11:21
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
@balloob @dshokouhi
Make automations log errors (home-assistant#18965)
ad04ba5
@balloob balloob mentioned this pull request Jan 10, 2019
Merged
@amelchio amelchio mentioned this pull request Jan 20, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@balloob balloob

Labels
cla-signed core integration: automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balloob @homeassistant