New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation log error #18965

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@balloob
Copy link
Member

balloob commented Dec 3, 2018

Description:

Requires #18962 to be merged

Automation component will now log any error raised from executing the script.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Dec 3, 2018

@wafflebot wafflebot bot added the in progress label Dec 3, 2018

@balloob balloob referenced this pull request Dec 3, 2018

Merged

Refactor script helper actions into their own methods #18962

4 of 4 tasks complete

@balloob balloob force-pushed the automation-log-error branch from 2368a00 to c0d6ce8 Dec 3, 2018

@balloob balloob force-pushed the automation-log-error branch from c0d6ce8 to 831d4f8 Dec 13, 2018

@balloob balloob merged commit 9d9e113 into dev Dec 13, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 92.886%
Details

@wafflebot wafflebot bot removed the in progress label Dec 13, 2018

@delete-merged-branch delete-merged-branch bot deleted the automation-log-error branch Dec 13, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

@amelchio amelchio referenced this pull request Jan 20, 2019

Merged

Remove double logging of automation action #20264

3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment