New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device registry to MQTT climate #19332

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@emontnemery
Copy link
Contributor

emontnemery commented Dec 15, 2018

Description:

Implements #16943 for climate.mqtt

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7864

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
'device': {
'identifiers': ['helloworld'],
'connections': [
["mac", "02:5b:26:a8:dc:12"],

This comment has been minimized.

@OttoWinter

OttoWinter Dec 16, 2018

Contributor

Funny how my macbook's MAC-address is now all over the HA codebase 😆

@emontnemery emontnemery force-pushed the emontnemery:mqtt-device-registry-climate branch from 2f0583c to a9de9aa Dec 19, 2018

@emontnemery emontnemery merged commit 27ea59f into home-assistant:dev Dec 19, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on mqtt-device-registry-climate at 93.038%
Details

@wafflebot wafflebot bot removed the in progress label Dec 19, 2018

@emontnemery emontnemery deleted the emontnemery:mqtt-device-registry-climate branch Dec 19, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment