Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device registry to MQTT climate #19332

Merged

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Dec 15, 2018

Description:

Implements #16943 for climate.mqtt

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7864

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

'device': {
'identifiers': ['helloworld'],
'connections': [
["mac", "02:5b:26:a8:dc:12"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny how my macbook's MAC-address is now all over the HA codebase 😆

@emontnemery emontnemery merged commit 27ea59f into home-assistant:dev Dec 19, 2018
@ghost ghost removed the in progress label Dec 19, 2018
@emontnemery emontnemery deleted the mqtt-device-registry-climate branch December 19, 2018 18:59
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants