Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imap_email_content: allow configuring folder to read. #20160

Merged
merged 3 commits into from Jan 16, 2019
Merged

imap_email_content: allow configuring folder to read. #20160

merged 3 commits into from Jan 16, 2019

Conversation

cvwillegen
Copy link
Contributor

Add configuration for selection of IMAP folder to track

Description:

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8190

Example entry for configuration.yaml (if applicable):

  - platform: imap_email_content
    server: imap.gmail.com
    username: XXXX
    password: XXXX
    folder: Spam

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@cvwillegen
Update imap_email_content.py
29f4f4a 
Add configuration for selection of IMAP folder to track
@ghost ghost added the in progress label Jan 16, 2019
@homeassistant homeassistant added the small-pr PRs with less than 30 lines. label Jan 16, 2019
@cvwillegen cvwillegen mentioned this pull request Jan 16, 2019
Merged
2 tasks
balloob
balloob approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge when conflict resolved.

@balloob balloob changed the title Update imap_email_content.py imap_email_content: allow configuring folder to read. Jan 16, 2019
@ghost ghost assigned balloob Jan 16, 2019
@balloob balloob merged commit 5e73846 into home-assistant:dev Jan 16, 2019
@ghost ghost removed the in progress label Jan 16, 2019
@cvwillegen cvwillegen deleted the patch-2 branch January 17, 2019 08:17
@balloob balloob mentioned this pull request Jan 23, 2019
Merged
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
@cvwillegen @alandtse
imap_email_content: allow configuring folder to read. (home-assistant…
9ad2fe0 
…#20160)

* Update imap_email_content.py

Add configuration for selection of IMAP folder to track

* Update imap_email_content.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@balloob balloob balloob approved these changes

Assignees

@balloob balloob

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cvwillegen @balloob @houndci-bot @homeassistant