Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix waze_travel_time component ERROR on startup #20316

Merged
merged 10 commits into from Feb 6, 2019
Merged

Fix waze_travel_time component ERROR on startup #20316

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4782838
Fix waze_travel_time component ERROR on startup
VirtualL Jan 22, 2019
6db7a19
add missing whitespace after ','
VirtualL Jan 22, 2019
52d8edf
fix line too long (80 > 79 characters)
VirtualL Jan 22, 2019
f09fee2
lint
VirtualL Jan 22, 2019
6758254
fix interval to use const
VirtualL Jan 23, 2019
938110b
Change to Throttle as a decorator to update
VirtualL Jan 23, 2019
2cd0714
fix indentations
VirtualL Feb 6, 2019
baaae6b
Update waze_travel_time.py
VirtualL Feb 6, 2019
960578a
Update waze_travel_time.py
VirtualL Feb 6, 2019
5fbd46d
Update waze_travel_time.py
VirtualL Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 10 additions & 4 deletions homeassistant/components/sensor/waze_travel_time.py
View file
Open in desktop
Expand Up @@ -5,6 +5,7 @@
https://home-assistant.io/components/sensor.waze_travel_time/
"""
from datetime import timedelta
from homeassistant.util import Throttle
import logging

import voluptuous as vol
Expand Down Expand Up @@ -39,7 +40,7 @@

REGIONS = ['US', 'NA', 'EU', 'IL', 'AU']

SCAN_INTERVAL = timedelta(minutes=5)
VirtualL marked this conversation as resolved.
Show resolved Hide resolved
CONF_UPDATE_INTERVAL = 'update_interval'

TRACKABLE_DOMAINS = ['device_tracker', 'sensor', 'zone']

Expand All @@ -51,6 +52,8 @@
vol.Optional(CONF_INCL_FILTER): cv.string,
vol.Optional(CONF_EXCL_FILTER): cv.string,
vol.Optional(CONF_REALTIME, default=DEFAULT_REALTIME): cv.boolean,
vol.Optional(CONF_UPDATE_INTERVAL, default=timedelta(minutes=5)):
VirtualL marked this conversation as resolved.
Show resolved Hide resolved
vol.All(cv.time_period, cv.positive_timedelta),
})


Expand All @@ -63,11 +66,13 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
incl_filter = config.get(CONF_INCL_FILTER)
excl_filter = config.get(CONF_EXCL_FILTER)
realtime = config.get(CONF_REALTIME)
update_interval = config.get(CONF_UPDATE_INTERVAL)

sensor = WazeTravelTime(name, origin, destination, region,
incl_filter, excl_filter, realtime)
incl_filter, excl_filter, realtime,
VirtualL marked this conversation as resolved.
Show resolved Hide resolved
update_interval)

add_entities([sensor])
add_entities([sensor], True)
VirtualL marked this conversation as resolved.
Show resolved Hide resolved

# Wait until start event is sent to load this component.
hass.bus.listen_once(
Expand All @@ -84,7 +89,7 @@ class WazeTravelTime(Entity):
"""Representation of a Waze travel time sensor."""

def __init__(self, name, origin, destination, region,
incl_filter, excl_filter, realtime):
incl_filter, excl_filter, realtime, interval):
VirtualL marked this conversation as resolved.
Show resolved Hide resolved
"""Initialize the Waze travel time sensor."""
self._name = name
self._region = region
Expand All @@ -94,6 +99,7 @@ def __init__(self, name, origin, destination, region,
self._state = None
self._origin_entity_id = None
self._destination_entity_id = None
self.update = Throttle(interval)(self.update)
VirtualL marked this conversation as resolved.
Show resolved Hide resolved

if origin.split('.', 1)[0] in TRACKABLE_DOMAINS:
self._origin_entity_id = origin
Expand Down