Fix minor homematicip cloud binary sensor issues #20398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: binary_sensor.homematicip_cloud
small-pr
|
@mxworm could you review this please? |
|
OK for me, can be merged. |
MartinHjelmare
changed the title
houndci-bot
reviewed
Jan 25, 2019
houndci-bot
reviewed
Jan 25, 2019
houndci-bot
reviewed
Jan 25, 2019
3 tasks
changed api version to 0.10.4
changed api version to 0.10.4
|
Can be merged when lint issues are fixed and build passes. |
|
checks are fine now =) |
fredrike
pushed a commit
to fredrike/home-assistant
that referenced
this pull request
Jan 30, 2019
* fix for smoke detection * a tilted window is now considered as "open"/on * changed comparison to enum * line length * insert brackets for line length and comparison * indentation should now be ok for hound changed api version to 0.10.4 * indentation should now be ok for hound changed api version to 0.10.4 * updating requirement files * satisfy lint
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
* fix for smoke detection * a tilted window is now considered as "open"/on * changed comparison to enum * line length * insert brackets for line length and comparison * indentation should now be ok for hound changed api version to 0.10.4 * indentation should now be ok for hound changed api version to 0.10.4 * updating requirement files * satisfy lint
kellerza
pushed a commit
to kellerza/home-assistant
that referenced
this pull request
Feb 24, 2019
* fix for smoke detection * a tilted window is now considered as "open"/on * changed comparison to enum * line length * insert brackets for line length and comparison * indentation should now be ok for hound changed api version to 0.10.4 * indentation should now be ok for hound changed api version to 0.10.4 * updating requirement files * satisfy lint
ghost
added
integration: homematicip_cloud
and removed
platform: binary_sensor.homematicip_cloud
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
the current version will think, that there is a smoke detected due an EnumValue != String comparison which will result to be always true -> smoke detected
additionally a tilted window will now be considered as open
Checklist:
tox. Your PR cannot be merged unless tests pass