Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SmartThings Binary Sensor platform #20699

Merged
merged 3 commits into from Feb 2, 2019
Merged

Add SmartThings Binary Sensor platform #20699

merged 3 commits into from Feb 2, 2019

Conversation

andrewsayre
Copy link
Member

Description:

Adds SmartThings Binary Sensor platform that represents SmartThings devices that have sensor-related capabilities. Highlights:

  • Supports 9 different types of SmartThings capabilities (see code/docs for list)
  • binary_sensor entities are automatically created for each capability supported by the device. Users will need to remove and reinstall the Home Assistant SmartApp/Automation in the SmartThings Classic mobile app if they have previously used this component.

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8388

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Feb 2, 2019
@ghost ghost assigned balloob Feb 2, 2019
@balloob balloob merged commit 6458abc into home-assistant:dev Feb 2, 2019
@ghost ghost removed the in progress label Feb 2, 2019
@balloob balloob added this to the 0.87.0 milestone Feb 2, 2019
balloob pushed a commit that referenced this pull request Feb 2, 2019
@andrewsayre @balloob
Add SmartThings Binary Sensor platform (#20699)
d3e011f 
* Add SmartThings binary_sensor platform

* Fixed comment typo.
@andrewsayre andrewsayre mentioned this pull request Feb 2, 2019
Merged
2 tasks
@andrewsayre andrewsayre deleted the feature-smartthings-binary_sensor branch February 2, 2019 22:42
@andrewsayre andrewsayre mentioned this pull request Feb 3, 2019
Merged
5 tasks
@balloob balloob mentioned this pull request Feb 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@balloob balloob balloob approved these changes

Assignees

@balloob balloob

Labels
cherry-picked cla-signed integration: smartthings
Projects
None yet
Milestone
0.87.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewsayre @balloob @MartinHjelmare @homeassistant