Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HomematicIP fix cover direction #20901

Merged
merged 3 commits into from Feb 11, 2019
Merged

HomematicIP fix cover direction #20901

merged 3 commits into from Feb 11, 2019

Conversation

worm-ee
Copy link
Contributor

@worm-ee worm-ee commented Feb 9, 2019 •
edited

Description:

Fix for the inverted cover direction.

**Related issue (if applicable): see comments: #19794 (comment)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost added the in progress label Feb 9, 2019
@worm-ee worm-ee changed the title [WIP] HomematicIP fix cover (froll/broll) direction [WIP] HomematicIP fix cover direction Feb 9, 2019
@worm-ee worm-ee changed the title [WIP] HomematicIP fix cover direction HomematicIP fix cover direction Feb 10, 2019
andrewsayre
andrewsayre requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix! Just a couple suggestions that will greatly improve maintainability!

homeassistant/components/homematicip_cloud/cover.py Outdated Show resolved Hide resolved
homeassistant/components/homematicip_cloud/cover.py Outdated Show resolved Hide resolved
@andrewsayre andrewsayre self-assigned this Feb 10, 2019
@andrewsayre
Copy link
Member

Can be merged once build completes

@amelchio amelchio merged commit e538320 into home-assistant:dev Feb 11, 2019
@ghost ghost removed the in progress label Feb 11, 2019
@FlavorFx
Copy link
Contributor

In which version did you merged it? Unfortunately in 0.89dev it has still the wrong direction.

@balloob balloob mentioned this pull request Feb 20, 2019
Merged
@tose60
Copy link

tose60 commented Feb 22, 2019

Have installed the official 0.89.1 release - The problem is not fixed yet in the release as far as I can see.

@MartinHjelmare
Copy link
Member

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewsayre andrewsayre andrewsayre approved these changes

Assignees

@andrewsayre andrewsayre

Labels
cla-signed integration: homematicip_cloud small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@worm-ee @andrewsayre @FlavorFx @tose60 @MartinHjelmare @homeassistant @amelchio