Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update denonavr to 0.7.8 (add various sound modes) #20951

Merged
merged 1 commit into from Feb 11, 2019
Merged

Update denonavr to 0.7.8 (add various sound modes) #20951

merged 1 commit into from Feb 11, 2019

Conversation

ol-iver
Copy link
Contributor

@ol-iver ol-iver commented Feb 10, 2019

Description:

  • Add sound modes 'DTS-HD MSTR', 'PURE DIRECT', 'PLIIX CINEMA', 'MCH STEREO'
  • Add sound modes Denon AVR-X2500H

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Feb 10, 2019
@ol-iver ol-iver mentioned this pull request Feb 10, 2019
Merged
@andrewsayre andrewsayre changed the title Add sound modes various sound modes Update denonavr to 0.7.8 (add various sound modes) Feb 10, 2019
andrewsayre
andrewsayre reviewed Feb 10, 2019
View reviewed changes
Copy link
Member

@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge once build completes

@andrewsayre andrewsayre merged commit 88d0aa1 into home-assistant:dev Feb 11, 2019
@ghost ghost removed the in progress label Feb 11, 2019
@balloob balloob mentioned this pull request Feb 20, 2019
Merged
@ol-iver ol-iver deleted the denonavr branch June 2, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsayre andrewsayre andrewsayre approved these changes

Assignees
No one assigned
Labels
cla-signed integration: denonavr small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ol-iver @andrewsayre @homeassistant