Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point alarm control #20972

Merged
merged 7 commits into from Feb 15, 2019
Merged

Point alarm control #20972

merged 7 commits into from Feb 15, 2019

Conversation

fredrike
Copy link
Contributor

@fredrike fredrike commented Feb 11, 2019 •
edited

Description:

Adds support for toggling the alarm part of the Minut Point.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8477

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Wip:

  • Community tests.
  • Version bump github.com/fredrike/pypoint.
  • (Supported features of alarm_control_panel), apparently doesn't the alarm_control_panel implement supported features like the climate platform does.

@ghost ghost added the in progress label Feb 11, 2019
@fredrike fredrike mentioned this pull request Feb 11, 2019
Merged
2 tasks
@fredrike fredrike changed the title wip: Point alarm control Point alarm control Feb 14, 2019
@MartinHjelmare MartinHjelmare merged commit f3786e2 into home-assistant:dev Feb 15, 2019
@ghost ghost removed the in progress label Feb 15, 2019
@fredrike
Copy link
Contributor Author

Will this reach 0.88?

@MartinHjelmare
Copy link
Member

No, 0.89.

@fredrike fredrike deleted the point-alarm_control branch March 4, 2019 06:54
@balloob balloob mentioned this pull request Mar 6, 2019
Merged
@fredrike fredrike mentioned this pull request Mar 7, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: point new-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fredrike @MartinHjelmare @homeassistant