Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point alarm control #20972

Merged
merged 7 commits into from Feb 15, 2019

Conversation

Projects
None yet
3 participants
@fredrike
Copy link
Contributor

fredrike commented Feb 11, 2019

Description:

Adds support for toggling the alarm part of the Minut Point.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8477

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Wip:

  • Community tests.
  • Version bump github.com/fredrike/pypoint.
  • (Supported features of alarm_control_panel), apparently doesn't the alarm_control_panel implement supported features like the climate platform does.

fredrike added some commits Feb 8, 2019

@fredrike fredrike changed the title wip: Point alarm control Point alarm control Feb 14, 2019

@fredrike fredrike force-pushed the fredrike:point-alarm_control branch from 1cd0bb8 to 589a173 Feb 14, 2019

@MartinHjelmare MartinHjelmare merged commit f3786e2 into home-assistant:dev Feb 15, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 92.791%
Details

@wafflebot wafflebot bot removed the in progress label Feb 15, 2019

@fredrike

This comment has been minimized.

Copy link
Contributor Author

fredrike commented Feb 15, 2019

Will this reach 0.88?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Feb 15, 2019

No, 0.89.

@fredrike fredrike deleted the fredrike:point-alarm_control branch Mar 4, 2019

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

@fredrike fredrike referenced this pull request Mar 7, 2019

Merged

Point does not support Arm_Home #8854

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.