Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump thermoworks_smoke version to get new pyrebase version #21100

Merged
merged 1 commit into from Feb 16, 2019

Conversation

Projects
None yet
5 participants
@nhorvath
Copy link
Contributor

commented Feb 15, 2019

Description:

Something must have changed on firebase that exposed an issue with double escaping quotes. I fixed the issue in Pyrebase and updated the dependencies in thermoworks_smoke.

Related issue (if applicable): fixes n/a

Pull request in home-assistant.io with documentation (if applicable): n/a

Example entry for configuration.yaml (if applicable):

n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@nhorvath

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

@MartinHjelmare can we fast track this one? Thanks.

@manueligno78
Copy link

left a comment

LGTM

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

Should we tag this for 0.88? It's a fix right?

@nhorvath

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

Yes it's a fix. It's currently broken due to external changes.

@MartinHjelmare MartinHjelmare added this to the 0.88.0 milestone Feb 16, 2019

@MartinHjelmare MartinHjelmare merged commit f7d9031 into home-assistant:dev Feb 16, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.804%
Details

@wafflebot wafflebot bot removed the in progress label Feb 16, 2019

balloob added a commit that referenced this pull request Feb 17, 2019

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.