Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SmartThings Cover platform and add cover device classes #21192

Merged
merged 6 commits into from Feb 25, 2019

Conversation

@andrewsayre
Copy link
Contributor

andrewsayre commented Feb 18, 2019

Description:

Adds SmartThings Cover platform that represents SmartThings devices that have open/close related capabilities. Highlights:

  • Supports open/close for doors, garage doors, and window shades.
  • Cover position is supported for device that implement the switchLevel capability.
  • Battery level is reported as a state attribute if the battery capability is implemented by the device.
  • Cover entities are automatically created if supported by the device.
  • Adds 6 new device classes to the Cover platform per home-assistant/architecture#153 (curtain, door, shade, shutter, blind, and awning)

BREAKING CHANGE: With the addition of the SmartThings Cover platform, the SmartThings Sensor platform will no longer represent Door, Garage Door and Window Share attributes. Additionally, if the cover device reports battery status, the value will be present as a state attribute (battery_level) and not a discrete sensor.

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8625

Pull request in developers.home-assistant with dev documentation: home-assistant/developers.home-assistant#187

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@andrewsayre andrewsayre force-pushed the andrewsayre:feature-smartthings-cover branch from 1169af6 to 4a2c28b Feb 24, 2019

@andrewsayre andrewsayre changed the title Add SmartThings cover platform and add cover device classes Add SmartThings Cover platform and add cover device classes Feb 24, 2019

@andrewsayre

This comment has been minimized.

Copy link
Contributor Author

andrewsayre commented Feb 24, 2019

@balloob Can you take a look at this when you get a chance? I think it's ready to move forward.

@andrewsayre andrewsayre requested a review from balloob Feb 24, 2019

Show resolved Hide resolved homeassistant/components/smartthings/cover.py Outdated
Show resolved Hide resolved homeassistant/components/smartthings/cover.py Outdated
Show resolved Hide resolved homeassistant/components/smartthings/cover.py Outdated
Show resolved Hide resolved homeassistant/components/smartthings/cover.py Outdated
Show resolved Hide resolved tests/components/smartthings/test_cover.py

andrewsayre added some commits Feb 18, 2019

@andrewsayre andrewsayre force-pushed the andrewsayre:feature-smartthings-cover branch from 5d248ca to c16c033 Feb 24, 2019

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Last comment I think.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Nice!

@balloob balloob merged commit d3f1ee4 into home-assistant:dev Feb 25, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 92.742%
Details

@wafflebot wafflebot bot removed the in progress label Feb 25, 2019

@andrewsayre andrewsayre deleted the andrewsayre:feature-smartthings-cover branch Feb 25, 2019

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.