New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SmartThings Cover platform and add cover device classes #21192
Merged
balloob
merged 6 commits into
home-assistant:dev
from
andrewsayre:feature-smartthings-cover
Feb 25, 2019
Merged
Add SmartThings Cover platform and add cover device classes #21192
balloob
merged 6 commits into
home-assistant:dev
from
andrewsayre:feature-smartthings-cover
Feb 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned andrewsayre
Feb 18, 2019
ghost
added
the
in progress
label
Feb 18, 2019
andrewsayre
force-pushed
the
feature-smartthings-cover
branch
from
February 22, 2019 23:11
1b0e6b5
to
2be5186
Compare
andrewsayre
force-pushed
the
feature-smartthings-cover
branch
from
February 24, 2019 02:06
1169af6
to
4a2c28b
Compare
andrewsayre
changed the title
Add SmartThings cover platform and add cover device classes
Add SmartThings Cover platform and add cover device classes
Feb 24, 2019
@balloob Can you take a look at this when you get a chance? I think it's ready to move forward. |
MartinHjelmare
requested changes
Feb 24, 2019
…er platform; Improve lock test coverage
andrewsayre
force-pushed
the
feature-smartthings-cover
branch
from
February 24, 2019 20:02
5d248ca
to
c16c033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment I think.
MartinHjelmare
approved these changes
Feb 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds SmartThings Cover platform that represents SmartThings devices that have open/close related capabilities. Highlights:
switchLevel
capability.battery
capability is implemented by the device.curtain
,door
,shade
,shutter
,blind
, andawning
)BREAKING CHANGE: With the addition of the SmartThings Cover platform, the SmartThings Sensor platform will no longer represent
Door
,Garage Door
andWindow Share
attributes. Additionally, if the cover device reports battery status, the value will be present as a state attribute (battery_level
) and not a discrete sensor.Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8625
Pull request in developers.home-assistant with dev documentation: home-assistant/developers.home-assistant#187
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: