Improve tolerance of SmartThings Climate platform #21383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
andrewsayre
force-pushed
the
fix-smartthings-climate-dth-tolerance
branch
from
f23e2ed
to
5b3987c
Compare
MartinHjelmare
approved these changes
Feb 24, 2019
|
Test failure is an unrelated flaky test. Merging. |
balloob
pushed a commit
that referenced
this pull request
Feb 27, 2019
* Improve resilience of platform with buggy handlers * Eliminate possibility of None in operation list * Refactor variable name
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change improves the tolerance in the SmartThings climate platform for custom device type handlers that do not properly implement the thermostat capability. This will allow the entities to load, but have partial functionality, compared to logging an error today, providing a better user experience until the root cause of the buggy device type handlers can be resolved.
Related issue (if applicable): fixes #21298
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: