Precompute logbook excluded events #21587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: logbook
integration: recorder
core
small-pr
ghost
added
in progress
and removed
integration: logbook
integration: recorder
core
small-pr
houndci-bot
reviewed
Mar 2, 2019
| try: | ||
| dbevent = Events.from_event(event) | ||
| for_logbook = logbook.keep_event(dbevent.to_native()) |
|
I decided that I don't like this. I think a more radical change is needed, this one has too many problems for too little benefit. |
|
For truly radicalism, home-assistant/architecture#110 proposes to compute the logbook line at the time of the event, and so the reader will just fetch lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A proposal for reducing the logbook load time by computing the exclude flag when the event is written (I realize that there are still some details missing).
@balloob @OverloadUT I wanted to get your opinion on this approach before spending more time on it. I am not yet sure what I think about it myself.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: