New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile_app improvements #21607
mobile_app improvements #21607
Conversation
@balloob A few things that need to be figured out for Cloudhooks support:
|
|
0418ceb
to
5538637
Compare
e2efcc4
to
380e722
Compare
@balloob Can you take a look at the work i've done in 78e8494 and give it a archetecture tuneup like only you can really provide? Not sure if we should continue just having this one function hang out or actually implement more of a class system. Also, I've had to remove the |
For testing & docs purposes, here's a valid registration payload: {
"app_data": {
"curl": true
},
"app_id": "io.homeassistant.curl",
"app_name": "cURL",
"app_version": "1.0.0",
"device_name": "MBP",
"manufacturer": "haxx.se",
"model": "cURL",
"os_version": "1.0",
"supports_encryption": true
} |
@balloob If there can be only one frontend fix for 0.89 in relation to |
@balloob Final comment of the night: I'm considering renaming this to something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few removals, then ok to merge.
Description:
This PR contains improvements to the existing
mobile_app
implementation work done in #21475.This PR depends on #21606 being merged.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:
tox
. Your PR cannot be merged unless tests pass