Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device HMIP-eTRV-C to HomematicIP #21612

Merged
merged 3 commits into from Mar 3, 2019
Merged

Add device HMIP-eTRV-C to HomematicIP #21612

merged 3 commits into from Mar 3, 2019

Conversation

SukramJ
Copy link
Contributor

@SukramJ SukramJ commented Mar 3, 2019

Description:

  • Update homematicip_cloud dependency to 0.10.6
  • Add device HMIP-eTRV-C to HomematicIP

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8810

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

add valveActualTemperature to HeatingThermostats (HMIP-eTRV-C, HMIP-eTRV, HMIP-eTRV-2)
@SukramJ
Copy link
Contributor Author

SukramJ commented Mar 3, 2019

Hi @mxworm,
have a look at this PR.
It also contains dependency updates.

BR
Markus

@worm-ee
Copy link
Contributor

worm-ee commented Mar 3, 2019

Hi Markus,

the temperature as a dedicated sensor is fine... lets go for.
Regarding the RSSI I would (after some sleep) add it as a attribute.

Ciao Mattias

@SukramJ
Copy link
Contributor Author

SukramJ commented Mar 3, 2019

Hi Mattias,

sounds good.
The pull request for rssi attribute is only closed, and my branch is still available.
I think we should wait what @MartinHjelmare or others might answer regarding rssi.

Thanks and BR
Markus

@SukramJ
Copy link
Contributor Author

SukramJ commented Mar 3, 2019

After discussion and some real testing it doesn't seem to be necessary to have temperature sensors for indoor thermostats. All indoor thermostats are part of a heating_group in Homematic IP, which are used for climate entities. So instead of using sensor.wallthermostat_living_room_temperature in an automation condition you could use value_template: '{{ states.climate.living_room.attributes.current_temperature < 27 }}', and just climate.living_room to display temperature in UI.

@SukramJ SukramJ closed this Mar 3, 2019
@ghost ghost removed the in progress label Mar 3, 2019
@SukramJ SukramJ reopened this Mar 3, 2019
@ghost ghost added the in progress label Mar 3, 2019
@SukramJ
Copy link
Contributor Author

SukramJ commented Mar 3, 2019

Just closed this PR by accident.

@MartinHjelmare
Copy link
Member

Can be merged when build passes. Make sure the PR description is up to date after the change in direction. I'm not sure it's not, just a friendly reminder.

@SukramJ
Copy link
Contributor Author

SukramJ commented Mar 3, 2019

PR description is up to date now.

@rohankapoorcom rohankapoorcom merged commit 3032283 into home-assistant:dev Mar 3, 2019
@ghost ghost removed the in progress label Mar 3, 2019
@SukramJ SukramJ deleted the HmIP-WTH-2-Update branch March 4, 2019 09:29
@balloob balloob mentioned this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants