Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device HMIP-eTRV-C to HomematicIP #21612

Merged
merged 3 commits into from Mar 3, 2019

Conversation

Projects
None yet
5 participants
@SukramJ
Copy link
Contributor

commented Mar 3, 2019

Description:

  • Update homematicip_cloud dependency to 0.10.6
  • Add device HMIP-eTRV-C to HomematicIP

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8810

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

SukramJ added some commits Mar 3, 2019

Add additional device HMIP-eTRV-C
add valveActualTemperature to HeatingThermostats (HMIP-eTRV-C, HMIP-eTRV, HMIP-eTRV-2)
@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

Hi @mxworm,
have a look at this PR.
It also contains dependency updates.

BR
Markus

@mxworm

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

Hi Markus,

the temperature as a dedicated sensor is fine... lets go for.
Regarding the RSSI I would (after some sleep) add it as a attribute.

Ciao Mattias

@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

Hi Mattias,

sounds good.
The pull request for rssi attribute is only closed, and my branch is still available.
I think we should wait what @MartinHjelmare or others might answer regarding rssi.

Thanks and BR
Markus

@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

After discussion and some real testing it doesn't seem to be necessary to have temperature sensors for indoor thermostats. All indoor thermostats are part of a heating_group in Homematic IP, which are used for climate entities. So instead of using sensor.wallthermostat_living_room_temperature in an automation condition you could use value_template: '{{ states.climate.living_room.attributes.current_temperature < 27 }}', and just climate.living_room to display temperature in UI.

@SukramJ SukramJ closed this Mar 3, 2019

@ghost ghost removed the in progress label Mar 3, 2019

@SukramJ SukramJ reopened this Mar 3, 2019

@ghost ghost added the in progress label Mar 3, 2019

@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

Just closed this PR by accident.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Can be merged when build passes. Make sure the PR description is up to date after the change in direction. I'm not sure it's not, just a friendly reminder.

@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

PR description is up to date now.

@rohankapoorcom rohankapoorcom merged commit 3032283 into home-assistant:dev Mar 3, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 92.745%
Details

@ghost ghost removed the in progress label Mar 3, 2019

@SukramJ SukramJ deleted the SukramJ:HmIP-WTH-2-Update branch Mar 4, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Mar 4, 2019

Merge branch 'dev' into current
* dev: (344 commits)
  Better output of workflow
  Upgrade youtube_dl to 2019.03.01 (home-assistant#21647)
  GitHub Workflow (home-assistant#21643)
  Fix actions with tox (home-assistant#21642)
  Replace travis (home-assistant#21641)
  Allow configuration of update interval for ness_alarm (home-assistant#21415)
  Updated frontend to 20190303.0
  Update translations
  Add storage helper to ZHA and use it for the device node descriptor (home-assistant#21500)
  Log exception occurred in WS service call command (home-assistant#21584)
  Fix calc next (home-assistant#21630)
  Expose create/delete cloudhook (home-assistant#21606)
  Return Netatmo climate operation_mode instead of boiler status (home-assistant#21633)
  Bump pyflunearyou to 1.0.3 (home-assistant#21634)
  fix derived rate, fixes home-assistant#20097 (home-assistant#21620)
  Add optional sender name for SendGrid (home-assistant#21610)
  Add 'app_name' property and 'apps' config entry to Fire TV (home-assistant#21601)
  Add device HMIP-eTRV-C to HomematicIP (home-assistant#21612)
  Bumping aioasuswrt (home-assistant#21627)
  SmartThings remove SmartApp/Automation on integration removal (home-assistant#21594)
  ...

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.